Skip to content

doc: update guidance for adding new modules #44576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 10 commits into from
Closed

doc: update guidance for adding new modules #44576

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b4b1ced
doc: update guidance for adding new modules
mhdawson Sep 8, 2022
9b3ae9a
squash:fixup
mhdawson Sep 8, 2022
e82833b
Update doc/contributing/collaborator-guide.md
Trott Sep 8, 2022
347453e
Update doc/contributing/collaborator-guide.md
Trott Sep 8, 2022
621a8b0
Update doc/contributing/collaborator-guide.md
Trott Sep 8, 2022
d129114
Update doc/contributing/collaborator-guide.md
Trott Sep 8, 2022
af6919e
Update doc/contributing/collaborator-guide.md
Trott Sep 8, 2022
a9fe2fe
Update doc/contributing/collaborator-guide.md
mhdawson Sep 9, 2022
0b19d4e
Update doc/contributing/collaborator-guide.md
mhdawson Sep 9, 2022
c524819
Update doc/contributing/collaborator-guide.md
mhdawson Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update doc/contributing/collaborator-guide.md
  • Loading branch information
@mhdawson
mhdawson authored Sep 9, 2022
commit c524819d362bcee641c48a3296b044e3cc09f26a
2 changes: 1 addition & 1 deletion doc/contributing/collaborator-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ New modules must only be added with the `node:` prefix.
When adding promises to an existing API, add `/promises`
(`inspector/promises`, etc.). Apply the `semver-major` label to the addition.
Copy link
Member

@ljharb ljharb Sep 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if node added a semver-major change that prevented any slashed requires/imports from core module names, then this category would no longer be semver-major after that.

(edit: oops, this was mentioned here: #44576 (comment) )

Copy link
Member

@targos targos Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #44651 for that.


If the new module name without the `node:` prefix is free, register
If the new module name is free in npm, register
a placeholder in the module registry as soon as possible. Link to the pull
request that introduces the new core module in the placeholder's `README`.

Expand Down