Skip to content

Conversation

panva
Copy link
Member

@panva panva commented Oct 3, 2022

  • adds null as an allowed deriveBits length
  • adds CFRG curves to supported algorithms lists

@panva panva added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. webcrypto commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Oct 3, 2022
@panva
Copy link
Member Author

panva commented Oct 3, 2022

cc @nodejs/crypto

@panva panva force-pushed the webcrypto-doc-fixes branch from 8f47f99 to c30b295 Compare October 3, 2022 11:45
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, messed up the order of comments. The previous comment is the same nit, essentially :)

@panva panva force-pushed the webcrypto-doc-fixes branch from c30b295 to ffdd070 Compare October 3, 2022 11:48
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2022
Copy link

@WaWa738 WaWa738 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3ab2d4f...2f47a5b

nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2022
PR-URL: #44876
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2022
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44876
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@panva panva deleted the webcrypto-doc-fixes branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants