Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
2f5f41c
cli: add `--watch`
MoLow Sep 29, 2022
0c9f38f
test: split watch mode inspector tests to sequential
MoLow Sep 29, 2022
3abd71a
test: deflake watch mode tests
MoLow Sep 29, 2022
36227ed
test: fix watch mode test flake
MoLow Sep 29, 2022
3c1e9d4
test_runner: support using `--inspect` with `--test`
MoLow Sep 10, 2022
7fb9cc7
cluster: use inspector utils
MoLow Sep 29, 2022
56c9c98
test: fix test-runner-inspect
MoLow Sep 29, 2022
f99f5d3
src: add detailed embedder process initialization API
addaleax Aug 5, 2022
576ccdf
util: increase robustness with primordials
ljharb Dec 16, 2021
c892f35
deps: V8: fix debug build
bnoordhuis Aug 25, 2022
984b0b4
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Sep 26, 2022
e9d572a
tools: update eslint to 8.24.0
nodejs-github-bot Sep 27, 2022
fd5c26b
path: change basename() argument from ext to suffix
Trott Sep 27, 2022
3ad0fae
tools: update eslint-check.js to object style
Sep 27, 2022
4db72a6
test: change the promises to async/await in test-debugger-exec-scope.js
Ankita-Khiratkar Sep 27, 2022
0b2e8b1
test: use async/await in test-debugger-profile
surbhirjain Sep 27, 2022
cca2535
test: use async/await in test-debugger-preserve-breaks
poorvitusam Sep 27, 2022
0fb669e
test: update test-debugger-breakpoint-exists.js to use async/await
archana-kamath Sep 27, 2022
af30823
test: upgrade all 1024 bit RSA keys to 2048 bits
mmomtchev Sep 3, 2022
f92871a
build: update timezone-update.yml
sashashura Sep 19, 2022
9864bde
test: modify test-debugger-custom-port.js to use async-await
pshastricb Sep 27, 2022
4efaf42
doc: remove "currently" and comma splice from child_process.md
Trott Sep 27, 2022
ab22777
tools: refactor deprecated format in no-unescaped-regexp-dot
sonimadhuri Sep 27, 2022
910fbd0
esm: fix duplicated test
GeoffreyBooth Sep 28, 2022
f8b2d7a
test: refactor to async/await
DivyaMohan94 Sep 28, 2022
9151439
dns: support dns module in the snapshot
joyeecheung Sep 14, 2022
4e82521
bootstrap: update comments in bootstrap/node.js
joyeecheung Sep 19, 2022
f85d347
child_process: remove lookup of undefined property
cjihrig Sep 24, 2022
dc6379b
fs: don't hard code name in validatePosition()
cjihrig Sep 24, 2022
5c63d14
test: add extra tests for basename with ext option
connorjburton Sep 29, 2022
eeabd23
test: use async/await in test-debugger-sb-before-load
hopeolaide Sep 29, 2022
e609a33
test: change promises to async/await in test-debugger-backtrace.js
zhangjuliet Sep 29, 2022
143c428
test: migrated from Promise chains to Async/Await
rathi2016 Sep 29, 2022
b27b336
src: remove ParseIP() in cares_wrap.cc
tniessen Sep 29, 2022
117f068
test: use async/await in test-debugger-auto-resume
samyuktaprabhu Sep 16, 2022
e0fbba0
crypto: use EVP_PKEY_CTX_set_dsa_paramgen_q_bits when available
davidben Sep 29, 2022
ddf0297
test: use async/await in test-debugger-heap-profiler
brindashar4 Sep 16, 2022
d2f3616
test: use async/await in test-debugger-random-port-with-inspect-port
Monu-Chaudhary Sep 16, 2022
f4f08be
test: use await in test-debugger-invalid-json
anjanakvellore Sep 29, 2022
8033ad8
test: update test-debugger-scripts to use await/async
mmeenapriya Sep 29, 2022
9f14625
test: use async/await in test-debugger-help
chanduMe Sep 29, 2022
ee3c6a4
test: use async/await in test-debugger-exceptions
pete3249 Sep 30, 2022
131adec
tools: fix typo in tools/update-authors.mjs
RaisinTen Sep 30, 2022
fd9feb3
meta: update AUTHORS
nodejs-github-bot Oct 2, 2022
2a5bce6
doc: include last security release date
vdeturckheim Oct 2, 2022
f300f19
stream: handle enqueuing chunks when a pending BYOB pull request exists
daeyeon Oct 2, 2022
7c5c19e
doc: update node prefix require.cache example
simoneb Oct 2, 2022
2efe4d9
meta: label test.js and test.md with test_runner label
MoLow Oct 2, 2022
ccf31d8
doc: add anchor link for --preserve-symlinks
cola119 Oct 2, 2022
c54cee1
test: check server status in test-tls-psk-client
richardlau Oct 2, 2022
8daceda
test: remove unused variable in addon test
joyeecheung Oct 2, 2022
6ae9bc8
doc: add extra step for reporter pre-approval
RafaelGSS Oct 2, 2022
60a05d6
test: skip some binding tests on IBMi PASE
richardlau Oct 2, 2022
dc2af26
test: improve lib/internal/source_map/source_map.js coverage
fossamagna Oct 3, 2022
a854bb3
node-api: create reference only when needed
Flarna Oct 3, 2022
37808b3
build: convert V8 test JSON to JUnit XML
kvakil Oct 3, 2022
c7ece46
test_runner: remove runtime experimental warning
cjihrig Oct 3, 2022
781ad96
src: use OnScopeLeave instead of multiple free()
tniessen Oct 3, 2022
780144c
doc: remove unnecessary leading commas
cjihrig Oct 4, 2022
67eaa30
lib: add cause to DOMException
flakey5 Oct 4, 2022
27b4b78
benchmark: add vm context global proxy benchmark
joyeecheung Sep 26, 2022
e92b074
doc: fix grammar in dns docs (#44850)
cjihrig Oct 4, 2022
d762a34
test_runner: add --test-name-pattern CLI flag
cjihrig Sep 1, 2022
fd99b17
tools: make `utils.SearchFiles` deterministic
brjsp Oct 4, 2022
7ca77dd
src: avoid X509_free in loops in crypto_x509.cc
tniessen Oct 4, 2022
daf3152
src: implement GetDetachedness() in MemoryRetainerNode
joyeecheung Sep 27, 2022
70f5502
doc,crypto: add null length to crypto.subtle.deriveBits
panva Oct 3, 2022
3c653cf
doc,crypto: add missing CFRG curve algorithms to supported lists
panva Oct 3, 2022
0606f92
src: deduplicate setting RSA OAEP label
tniessen Oct 5, 2022
3abb607
src: remove UncheckedMalloc(0) workaround
tniessen Oct 5, 2022
4c869c8
http: add writeEarlyHints function to ServerResponse
wingleung Aug 17, 2022
a33cc22
src,worker: fix race of WorkerHeapSnapshotTaker
ywave620 Oct 6, 2022
3627616
doc,crypto: mark experimental algorithms more visually
panva Oct 6, 2022
9c7e664
http2: make early hints generic
anonrig Oct 6, 2022
67fb765
fs: improve promise based readFile performance for big files
BridgeAR Oct 6, 2022
eb19b1e
http: be more aggressive to reply 400, 408 and 431
ywave620 Oct 6, 2022
b6b9c42
doc: move release keys we don't use anymore in README
Trott Oct 7, 2022
ada7d82
lib: require JSDoc in internal validators code
Trott Oct 5, 2022
a080608
test: check `--test` is disallowed in NODE_OPTIONS
cola119 Oct 7, 2022
db5aeed
util: add default value option to parsearg
Eomm Oct 7, 2022
fe91beb
test: loosen test for negative timestamps in `test-fs-stat-date`
LiviaMedeiros Oct 7, 2022
2308b71
test: don't clobber RegExp.$_ on startup
bnoordhuis Oct 7, 2022
d08b024
doc: fix typo in Node.js 12 changelog
lorand-horvath Oct 7, 2022
aa68d40
deps: update corepack to 0.14.2
nodejs-github-bot Oct 8, 2022
ddb5402
doc: fix label name in collaborator guide
Trott Oct 8, 2022
653c3b1
buffer,lib: update atob to align wpt's base64.json
XadillaX Jul 19, 2022
ad8b8ae
tools: update eslint to 8.25.0
nodejs-github-bot Oct 9, 2022
0db86ee
meta: update AUTHORS
nodejs-github-bot Oct 9, 2022
a90386b
deps: update undici to 5.11.0
nodejs-github-bot Oct 9, 2022
842bc64
doc: remove Legacy status from querystring
Trott Oct 9, 2022
11d1c23
fs: add `FileHandle.prototype.readLines`
aduh95 Oct 10, 2022
8c69da8
doc: mention `corepack prepare` supports tag or range
mrienstra Oct 10, 2022
9f2dd48
src: remove uid_t/gid_t casts
tniessen Oct 10, 2022
803fbfb
process: fix uid/gid validation to avoid crash
tniessen Oct 10, 2022
99a2c16
crypto: add causes to applicable webcrypto's OperationError
panva Oct 10, 2022
281fd7a
src,stream: improve DoWrite() and Write()
ywave620 Oct 10, 2022
725be0e
buffer: initialize TextDecoder once on blob.text()
anonrig Oct 10, 2022
19d8574
tools: fix timezone update tool
RaisinTen Oct 3, 2022
4bdef48
tools: remove faulty early termination logic from update-timezone.mjs
RaisinTen Oct 3, 2022
bc00f3b
fs: fix opts.filter issue in cp async
thoqbk Oct 10, 2022
b9b671f
test: debug watch mode inspect
MoLow Oct 10, 2022
97df9b8
doc: improve building doc for Android
MeowShe Oct 10, 2022
ce3cb29
doc: add fsPromises.readFile() example
bnb Oct 11, 2022
3f20e5b
lib: refactor transferable AbortSignal
flakey5 Jul 29, 2022
9ac029e
test: bump memory limit for abort fatal error
danielleadams Oct 13, 2022
8c1dd95
2022-10-13, Version 18.11.0 (Current)
danielleadams Oct 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: remove faulty early termination logic from update-timezone.mjs
We do not build Node.js in the workflow so
https://github.com/nodejs/node/blob/f4815fcd7691364d8139b44c1295dbc46f6ee4a8/tools/update-timezone.mjs#L18
is actually the version of `tzdata` in the Node.js in the runner instead
of what's in `main`.

The script is pretty fast even when the versions differ and there is an
update, so this optimization doesn't seem to be worth having given the
problem.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #44870
Fixes: #44865
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
  • Loading branch information
RaisinTen authored and danielleadams committed Oct 11, 2022
commit 4bdef48732cdaa40ed049697b884fcc4515d8299
7 changes: 0 additions & 7 deletions tools/update-timezone.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Usage: tools/update-timezone.mjs
import { execSync } from 'node:child_process';
import { renameSync, readdirSync, rmSync } from 'node:fs';
import { exit } from 'node:process';

const fileNames = [
'zoneinfo64.res',
Expand All @@ -15,14 +14,8 @@ const availableVersions = readdirSync('icu-data/tzdata/icunew', { withFileTypes:
.filter((dirent) => dirent.isDirectory())
.map((dirent) => dirent.name);

const currentVersion = process.versions.tz;
const latestVersion = availableVersions.sort().at(-1);

if (latestVersion === currentVersion) {
console.log(`Terminating early, tz version is latest @ ${currentVersion}`);
exit();
}

execSync('bzip2 -d deps/icu-small/source/data/in/icudt*.dat.bz2');
fileNames.forEach((file) => {
renameSync(`icu-data/tzdata/icunew/${latestVersion}/44/le/${file}`, `deps/icu-small/source/data/in/${file}`);
Expand Down