Skip to content

stream: fix pipeline calling end on destination more than once #46226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2023
Merged

stream: fix pipeline calling end on destination more than once #46226

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef7b83f
stream: fix pipeline calling end on destination more than once
debadree25 Jan 16, 2023
111281c
fixup! add comment
debadree25 Jan 16, 2023
518210f
fixup! comment fix
debadree25 Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! add comment
  • Loading branch information
@debadree25
debadree25 committed Jan 16, 2023
commit 111281c952b5c8c9473fb24fa3b50b8f76e7fda0
2 changes: 1 addition & 1 deletion lib/internal/streams/pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ function pipe(src, dst, finish, { end }) {
}
});

src.pipe(dst, { end: false });
src.pipe(dst, { end: false }); // If end is true we already will have a listener to end 'dst'.

if (end) {
// Compat. Before node v10.12.0 stdio used to throw an error so
Expand Down