Add listening method to net + tests #4743

cusspvz · 2016-01-18T13:38:14Z

Added:

listening method into net
Added test for net module
Added test for http module, since it inherits properties from net

closes #4735

mscdex · 2016-01-18T16:40:08Z

I think a boolean property (either normal or a getter) might be a better fit for this.

cusspvz · 2016-01-18T16:49:57Z

@mscdex deal. Gonna change it.

jasnell · 2016-01-18T16:51:52Z

This is fine. Just a thought but setting this up as a read-only property instead of a method might be worthwhile... e.g

Object.defineProperty(Server.prototype, 'listening', {
  configurable: false,
  enumerable: true,
  get : function() {
    return !! this._handle;
  }
});

Another thing, @cusspvz ... would you be able to update the commit log to match the style guidelines outlined here

cjihrig · 2016-01-18T16:53:32Z

Can you also run make jslint.

cjihrig · 2016-01-18T16:54:14Z

test/parallel/test-http-listening.js

This empty line is not needed.

jasnell · 2016-01-18T17:01:27Z

lib/net.js

I'd simply omit the set here. There's no reason to add a new throw as this can easily be marked as read only in the documentation

Instead of having a setter that throws, maybe just make writable: false

jasnell · 2016-01-18T17:02:16Z

Thank you for bearing with us :-) It's looking good. One other thing this will need is documentation for the new property to be added to /doc/api/net.markdown

cjihrig · 2016-01-18T17:03:30Z

lib/net.js

Can you split these across lines?

Also, why is enumerable not true?

I've changed to true already. :)

Should i stick configurable as true as well?

I don't personally see a need to make it configurable.

cusspvz · 2016-01-18T17:04:59Z

@jasnell

I've setup property definition into the Server constructor because I was doubting if it would pass the right context if it is defined on it's property.

Object.defineProperty(Server.prototype, 'listening', {
  get : function() {
    return !! this._handle;
  },
  configurable: false, enumerable: true,
});

Does that work?

jasnell · 2016-01-18T17:13:05Z

It doesn't need to go into the constructor. When the getter function is invoked it will be passed the appropriate this. If you do the defineProperty within the constructor however, you should change the first argument from Server.prototype to this, but I would just leave it outside of the constructor.

cusspvz · 2016-01-18T17:18:33Z

Think I did all requested changes. I just have to run the make jslint command. I will let you know how it went after my coffee break. Thank you all for the tips! :)

jasnell · 2016-01-18T17:29:39Z

test/parallel/test-http-listening.js

these should be const :-)

jasnell · 2016-01-18T17:30:13Z

Looking good, almost there! I left one more comment. I'll run CI once that's addressed

cjihrig · 2016-01-18T17:33:50Z

doc/api/http.markdown

"Returns a Boolean indicating whether or not the server is listening for connections."

cjihrig · 2016-01-18T18:06:25Z

This could probably use additional tests to at least verify that the value is false after a close().

cusspvz · 2016-01-21T21:50:17Z

@evanlucas looks good?

Added a listening property into net.Server.prototype indicating if the server is listening or not for connections. Other Server constructors that rely on net.Server should also gain access to this property. Also included tests for net and http subsystems. PR-URL: #4743 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

evanlucas · 2016-01-21T22:35:58Z

Landed in 5ef9989. Thanks for the contribution @cusspvz!!

cusspvz · 2016-01-22T19:54:45Z

You're welcome @evanlucas . Would this be merged also on current LTS versions? Thanks :)

evanlucas · 2016-01-22T20:08:12Z

I don't see it landing on v4.x unless another semver-minor version is going out for LTS, but do see it landing in v5.x.

jasnell · 2016-01-23T01:47:42Z

yeah, the general approach is to avoid landing semver-minor or higher in LTS tho there's going to be a rare exception here soon to land a couple of v8 profiling improvements. While I'm very happy to see this land, I'm not sure it rises to the level of something we'd land in v4 at this point.

cusspvz · 2016-01-23T02:05:09Z

Just asked because I have some modules where I'm gonna use this feature, and they must have compability with LTS versions.

But I was guessing, seems right, since this is not a patch. Thanks once again! :)

jasnell · 2016-01-23T02:09:51Z

understood... and something @nodejs/lts should keep in mind. It ought to be something that's fairly simple to polyfill to ensure the API use is consistent tho. I know that's not an overly helpful answer tho

Added a listening property into net.Server.prototype indicating if the server is listening or not for connections. Other Server constructors that rely on net.Server should also gain access to this property. Also included tests for net and http subsystems. PR-URL: #4743 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

* buffer: - You can now supply an encoding argument when filling a Buffer Buffer#fill(string[, start[, end]][, encoding]), supplying an existing Buffer will also work with Buffer#fill(buffer[, start[, end]]). See the API documentation for details on how this works. (Trevor Norris) #4935 - Buffer#indexOf() no longer requires a byteOffset argument if you also wish to specify an encoding: Buffer#indexOf(val[, byteOffset][, encoding]). (Trevor Norris) #4803 * child_process: spawn() and spawnSync() now support a 'shell' option to allow for optional execution of the given command inside a shell. If set to true, cmd.exe will be used on Windows and /bin/sh elsewhere. A path to a custom shell can also be passed to override these defaults. On Windows, this option allows .bat. and .cmd files to be executed with spawn() and spawnSync(). (Colin Ihrig) #4598 * http_parser: Update to http-parser 2.6.2 to fix an unintentionally strict limitation of allowable header characters. (James M Snell) #5237 * dgram: socket.send() now supports accepts an array of Buffers or Strings as the first argument. See the API docs for details on how this works. (Matteo Collina) #4374 * http: Fix a bug where handling headers will mistakenly trigger an 'upgrade' event where the server is just advertising its protocols. This bug can prevent HTTP clients from communicating with HTTP/2 enabled servers. (Fedor Indutny) #4337 * net: Added a listening Boolean property to net and http servers to indicate whether the server is listening for connections. (José Moreira) #4743 * node: The C++ node::MakeCallback() API is now reentrant and calling it from inside another MakeCallback() call no longer causes the nextTick queue or Promises microtask queue to be processed out of order. (Trevor Norris) #4507 * tls: Add a new tlsSocket.getProtocol() method to get the negotiated TLS protocol version of the current connection. (Brian White) #4995 * vm: Introduce new 'produceCachedData' and 'cachedData' options to new vm.Script() to interact with V8's code cache. When a new vm.Script object is created with the 'produceCachedData' set to true a Buffer with V8's code cache data will be produced and stored in cachedData property of the returned object. This data in turn may be supplied back to another vm.Script() object with a 'cachedData' option if the supplied source is the same. Successfully executing a script from cached data can speed up instantiation time. See the API docs for details. (Fedor Indutny) #4777 * performance: Improvements in: - process.nextTick() (Ruben Bridgewater) #5092 - path module (Brian White) #5123 - querystring module (Brian White) #5012 - streams module when processing small chunks (Matteo Collina) #4354

* buffer: - You can now supply an encoding argument when filling a Buffer Buffer#fill(string[, start[, end]][, encoding]), supplying an existing Buffer will also work with Buffer#fill(buffer[, start[, end]]). See the API documentation for details on how this works. (Trevor Norris) #4935 - Buffer#indexOf() no longer requires a byteOffset argument if you also wish to specify an encoding: Buffer#indexOf(val[, byteOffset][, encoding]). (Trevor Norris) #4803 * child_process: spawn() and spawnSync() now support a 'shell' option to allow for optional execution of the given command inside a shell. If set to true, cmd.exe will be used on Windows and /bin/sh elsewhere. A path to a custom shell can also be passed to override these defaults. On Windows, this option allows .bat. and .cmd files to be executed with spawn() and spawnSync(). (Colin Ihrig) #4598 * http_parser: Update to http-parser 2.6.2 to fix an unintentionally strict limitation of allowable header characters. (James M Snell) #5237 * dgram: socket.send() now supports accepts an array of Buffers or Strings as the first argument. See the API docs for details on how this works. (Matteo Collina) #4374 * http: Fix a bug where handling headers will mistakenly trigger an 'upgrade' event where the server is just advertising its protocols. This bug can prevent HTTP clients from communicating with HTTP/2 enabled servers. (Fedor Indutny) #4337 * net: Added a listening Boolean property to net and http servers to indicate whether the server is listening for connections. (José Moreira) #4743 * node: The C++ node::MakeCallback() API is now reentrant and calling it from inside another MakeCallback() call no longer causes the nextTick queue or Promises microtask queue to be processed out of order. (Trevor Norris) #4507 * tls: Add a new tlsSocket.getProtocol() method to get the negotiated TLS protocol version of the current connection. (Brian White) #4995 * vm: Introduce new 'produceCachedData' and 'cachedData' options to new vm.Script() to interact with V8's code cache. When a new vm.Script object is created with the 'produceCachedData' set to true a Buffer with V8's code cache data will be produced and stored in cachedData property of the returned object. This data in turn may be supplied back to another vm.Script() object with a 'cachedData' option if the supplied source is the same. Successfully executing a script from cached data can speed up instantiation time. See the API docs for details. (Fedor Indutny) #4777 * performance: Improvements in: - process.nextTick() (Ruben Bridgewater) #5092 - path module (Brian White) #5123 - querystring module (Brian White) #5012 - streams module when processing small chunks (Matteo Collina) #4354 PR-URL: #5295

Added a listening property into net.Server.prototype indicating if the server is listening or not for connections. Other Server constructors that rely on net.Server should also gain access to this property. Also included tests for net and http subsystems. PR-URL: nodejs#4743 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

r-52 added http Issues or PRs related to the http subsystem. net Issues and PRs related to the net subsystem. and removed http Issues or PRs related to the http subsystem. labels Jan 18, 2016

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 18, 2016

cjihrig reviewed Jan 18, 2016
View reviewed changes

test/parallel/test-http-listening.js Outdated

Copy link

Contributor

cjihrig Jan 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line is not needed.

cusspvz changed the title ~~Add listening method to net + tests~~ [WIP] Add listening method to net + tests Jan 18, 2016

jasnell reviewed Jan 18, 2016
View reviewed changes

cjihrig reviewed Jan 18, 2016
View reviewed changes

cusspvz force-pushed the feature/net.listening branch from 0818c00 to 798b568 Compare January 18, 2016 17:16

cusspvz changed the title ~~[WIP] Add listening method to net + tests~~ Add listening method to net + tests Jan 18, 2016

jasnell reviewed Jan 18, 2016
View reviewed changes

test/parallel/test-http-listening.js Outdated

Copy link

Member

jasnell Jan 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be const :-)

cjihrig reviewed Jan 18, 2016
View reviewed changes

doc/api/http.markdown Outdated

Copy link

Contributor

cjihrig Jan 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Returns a Boolean indicating whether or not the server is listening for connections."

cusspvz force-pushed the feature/net.listening branch from 798b568 to eb227d8 Compare January 18, 2016 19:08

cusspvz force-pushed the feature/net.listening branch from b4c04c7 to 045a757 Compare January 19, 2016 19:19

evanlucas closed this Jan 21, 2016

evanlucas added the land-on-v5.x label Jan 22, 2016

rvagg mentioned this pull request Feb 8, 2016

Release proposal: v5.5.1 (Stable) #5141

Closed

rvagg mentioned this pull request Feb 18, 2016

Release proposal: 5.7.0 (Stable) #5295

Merged

pvsousalima mentioned this pull request Nov 1, 2016

name net anonymous functions #9357

Closed

2 tasks

MylesBorins added lts-agenda labels Jan 6, 2017

MylesBorins mentioned this pull request Jan 6, 2017

Potential Semver Minor Backports nodejs/Release#177

Closed

9 tasks

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Jan 16, 2017

gene-pavlovsky mentioned this pull request Jul 9, 2018

js.node.net.Server: add listening boolean property HaxeFoundation/hxnodejs#104

Merged

Uh oh!

Add listening method to net + tests #4743

Add listening method to net + tests #4743

Uh oh!

Conversation

cusspvz commented Jan 18, 2016

Uh oh!

mscdex commented Jan 18, 2016

Uh oh!

cusspvz commented Jan 18, 2016

Uh oh!

jasnell commented Jan 18, 2016

Uh oh!

cjihrig commented Jan 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Jan 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cusspvz commented Jan 18, 2016

Uh oh!

jasnell commented Jan 18, 2016

Uh oh!

cusspvz commented Jan 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Jan 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Jan 18, 2016

Uh oh!

cusspvz commented Jan 21, 2016

Uh oh!

evanlucas commented Jan 21, 2016

Uh oh!

cusspvz commented Jan 22, 2016

Uh oh!

evanlucas commented Jan 22, 2016

Uh oh!

jasnell commented Jan 23, 2016

Uh oh!

cusspvz commented Jan 23, 2016

Uh oh!

jasnell commented Jan 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants