Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 18, 2023

This should fix the linter error on main.

@aduh95 aduh95 marked this pull request as ready for review April 18, 2023 16:49
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. wasi Issues and PRs related to the WebAssembly System Interface. labels Apr 18, 2023
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 changed the title doc: fix history ordering of WASI constructor doc: fix lint error in wasi.md Apr 18, 2023
PR-URL: nodejs#47611
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott merged commit bc445fa into nodejs:main Apr 18, 2023
@Trott
Copy link
Member

Trott commented Apr 18, 2023

Landed in bc445fa

@aduh95 aduh95 deleted the wasi-doc-lint branch April 18, 2023 19:41
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47611
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. wasi Issues and PRs related to the WebAssembly System Interface.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants