Skip to content

test_runner: add shards support #48639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 5, 2023
Merged

test_runner: add shards support #48639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a93fa41
test_runner: add shards support
rluvaton Jul 2, 2023
3bc36b8
test_runner: add validations
rluvaton Jul 2, 2023
bf9d2e5
test_runner: add tests for the shards
rluvaton Jul 2, 2023
3663fb2
reset unwanted changes
rluvaton Jul 2, 2023
09c8734
do not mutate array
rluvaton Jul 2, 2023
ed19709
update validation
rluvaton Jul 3, 2023
5e39d75
allow passing shards in CLI
rluvaton Jul 3, 2023
5c6ab88
test_runner: add cli support
rluvaton Jul 3, 2023
d293da5
test_runner: added docs
rluvaton Jul 3, 2023
51f7697
remove comment
rluvaton Jul 3, 2023
0625b75
format
rluvaton Jul 3, 2023
2e0040b
fix example
rluvaton Jul 3, 2023
602f767
test_runner: replace shards option with shard and --test-shard
rluvaton Jul 3, 2023
4ce4d76
test_runner: used stricter shard validation
rluvaton Jul 3, 2023
b7009d7
update node man page
rluvaton Jul 3, 2023
76cfcb6
test_runner: update based on CR
rluvaton Jul 3, 2023
5a846d2
test_runner: update based on the CR
rluvaton Jul 3, 2023
d4f9168
fix test
rluvaton Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: update based on the CR
  • Loading branch information
@rluvaton
rluvaton committed Jul 3, 2023
commit 5a846d2536f1c03857cefd5b7506602058acd18f
7 changes: 5 additions & 2 deletions lib/internal/main/test_runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ const {
ERR_INVALID_ARG_VALUE,
},
} = require('internal/errors');
const { NumberParseInt, RegExpPrototypeExec, StringPrototypeSplit } =
primordials;
const {
NumberParseInt,
RegExpPrototypeExec,
StringPrototypeSplit,
} = primordials;

prepareMainThreadExecution(false);
markBootstrapComplete();
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/test_runner/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ function run(options) {
if (shard != null) {
validateObject(shard, 'options.shard');
// Avoid re-evaluating the shard object in case it's a getter
shard = { index: shard.index, total: shard.total };
shard = { __proto__: null, index: shard.index, total: shard.total };

validateInteger(shard.total, 'options.shard.total', 1);
validateInteger(shard.index, 'options.shard.index');
Expand Down