Skip to content

net: fix readable event not emitted (fixes #25969) #48866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

net: fix readable event not emitted (fixes #25969) #48866

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07b336d
net: fix readable event not emitted
CGQAQ Jul 21, 2023
7da469e
net: call resume in internalConnnect
CGQAQ Jul 22, 2023
744d971
net: add semi;
CGQAQ Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,8 +1582,10 @@ function afterConnect(status, handle, req, readable, writable) {

// Start the first read, or get an immediate EOF.
// this doesn't actually consume any bytes, because len=0.
if (readable && !self.isPaused())
if (readable) {
self.read(0);
}

if (self[kPerfHooksNetConnectContext] && hasObserver('net')) {
stopPerf(self, kPerfHooksNetConnectContext);
}
Expand Down