Skip to content

doc: document deprecation of util._extend #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed

doc: document deprecation of util._extend #4902

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
10ba94f
Refactor self=this
benjamingr Jan 24, 2016
60e4ad3
Update self=this in http.js
benjamingr Jan 24, 2016
1ebb5b2
Refactor self=this to arrows
benjamingr Jan 24, 2016
dd96a00
fix leading whitespace linter issue
benjamingr Jan 24, 2016
889f467
fix emberrasing mistake
benjamingr Jan 25, 2016
5f8b49d
doc: undo move http.IncomingMessage.statusMessage
techjeffharris Jan 22, 2016
e82760f
doc: check for errors in 'listen' event
benjamingr Jan 24, 2016
efc4f01
vm: introduce `cachedData`/`produceCachedData`
indutny Jan 21, 2016
0e16694
test: mark test-tick-processor flaky
Trott Jan 21, 2016
29775ae
stream: refactor redeclared variables
Trott Jan 22, 2016
1164bcb
doc: fix code type of markdowns
JacksonTian Jan 25, 2016
d3ce9d3
doc: add `servername` parameter docs
estliberitas Jan 17, 2016
085c5a0
dns: throw a TypeError in lookupService with invalid port
evanlucas Jan 24, 2016
38aa39d
test: refactor test-net-settimeout
Trott Jan 21, 2016
516d5da
test: fs.link() test runs on same device
drewfish Jan 25, 2016
935768b
tools: enable assorted ESLint error rules
silverwind Jan 25, 2016
a6f50c6
test: fix irregular whitespace issue
silverwind Jan 25, 2016
db19416
src: attach error to stack on displayErrors
cjihrig Jan 26, 2016
25c4f98
tools: add support for subkeys in release tools
MylesBorins Jan 21, 2016
1348386
doc: fix nonsensical grammar in Buffer::write
Jimbly Jan 25, 2016
69176e1
doc: keep the names in sorted order
thefourtheye Jan 26, 2016
4b876bf
doc: remove unnecessary bind(this)
wKich Jan 21, 2016
5d8a742
tls: scope loop vars with let
Trott Jan 25, 2016
e99a50d
test: scope redeclared variable
Trott Jan 14, 2016
ae09fc2
doc: document deprecation of util._extend
benjamingr Jan 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: scope redeclared variable 
`test-assert.js` redeclares a variable with `var`. This change converts
it to a `const` declaration and wraps it in a standalone block to scope
it to just the test that uses it.

PR-URL: #4854
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
  • Loading branch information
@Trott @benjamingr
Trott authored and benjamingr committed Jan 27, 2016
commit e99a50db8f0d6820fe2a054b2c54700bc635d2cf
17 changes: 10 additions & 7 deletions test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,11 @@ assert.throws(makeBlock(a.deepEqual, /a/i, /a/));
assert.throws(makeBlock(a.deepEqual, /a/m, /a/));
assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im));

var re1 = /a/;
re1.lastIndex = 3;
assert.throws(makeBlock(a.deepEqual, re1, /a/));
{
const re1 = /a/;
re1.lastIndex = 3;
assert.throws(makeBlock(a.deepEqual, re1, /a/));
}


// 7.4
Expand Down Expand Up @@ -172,10 +174,11 @@ assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/));
assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/));
assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im));

var re1 = /a/;
re1.lastIndex = 3;
assert.throws(makeBlock(a.deepStrictEqual, re1, /a/));

{
const re1 = /a/;
re1.lastIndex = 3;
assert.throws(makeBlock(a.deepStrictEqual, re1, /a/));
}

// 7.4 - strict
assert.throws(makeBlock(a.deepStrictEqual, 4, '4'),
Expand Down