Skip to content

test: reduce flakiness of test-esm-loader-hooks #49248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2023
Merged

test: reduce flakiness of test-esm-loader-hooks #49248

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7830813
test: reduce flakiness of `test-esm-loader-hooks`
aduh95 Aug 19, 2023
8bce651
fixup! test: reduce flakiness of `test-esm-loader-hooks`
aduh95 Aug 19, 2023
93b4ee7
fixup! fixup! test: reduce flakiness of `test-esm-loader-hooks`
aduh95 Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions test/es-module/test-esm-loader-hooks.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ describe('Loader hooks', { concurrency: true }, () => {
`
import {MessageChannel} from 'node:worker_threads';
import {register} from 'node:module';
import {setTimeout} from 'node:timers/promises';
import {once} from 'node:events';
const {port1, port2} = new MessageChannel();
port1.on('message', (msg) => {
console.log('message', msg);
Expand All @@ -610,8 +610,12 @@ describe('Loader hooks', { concurrency: true }, () => {
);
console.log('register', result);

await import('node:os');
await setTimeout(99); // delay to limit flakiness
const timeout = setTimeout(() => {}, 2**31 - 1); // to keep the process alive.
await Promise.all([
once(port1, 'message').then(() => once(port1, 'message')),
import('node:os'),
]);
clearTimeout(timeout);
port1.close();
`,
]);
Expand Down