Skip to content

lib: allow byob reader for 'blob.stream()' #49713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2023
Merged

lib: allow byob reader for 'blob.stream()' #49713

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50ab557
lib: allow byob reader for 'blob.stream()'
debadree25 Sep 19, 2023
23cf23f
fixup! fix structured cloning wpt and add comments
debadree25 Sep 19, 2023
7e446f1
fixup! lint
debadree25 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fix structured cloning wpt and add comments
  • Loading branch information
@debadree25
debadree25 committed Sep 19, 2023
commit 23cf23ff6f010af64edbeb6bb5aa7949fa256b48
6 changes: 5 additions & 1 deletion lib/internal/blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ class Blob {
if (status === 0) {
// EOS
c.close();
// this is to signal the end for byob readers
// see https://streams.spec.whatwg.org/#example-rbs-pull
c.byobRequest?.respond(0);
const pending = this.pendingPulls.shift();
pending.resolve();
Expand All @@ -354,7 +356,9 @@ class Blob {
pending.reject(error);
return;
}
if (buffer !== undefined) {
// ReadableByteStreamController.enqueue errors if we submit a 0-length
// buffer. We need to check for that here.
if (buffer !== undefined && buffer.byteLength !== 0) {
c.enqueue(new Uint8Array(buffer));
}
// We keep reading until we either reach EOS, some error, or we
Expand Down