Skip to content

tls: add getProtocol() to TLS sockets #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscdex wants to merge 2 commits into from
Closed

tls: add getProtocol() to TLS sockets #4995

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c6e523
tls: add getProtocol() to TLS sockets
mscdex Jan 31, 2016
94f9b2c
doc: correct tlsSocket.getCipher() description
mscdex Jan 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: correct tlsSocket.getCipher() description 
getCipher() actually includes the protocol version that the cipher was
first supported and *not* the negotiated protocol of the current
connection.
  • Loading branch information
@mscdex
mscdex committed Jan 31, 2016
commit 94f9b2cbf9367a25f6140c38c72d8ab30a3fcd74
7 changes: 4 additions & 3 deletions doc/api/tls.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,14 +434,15 @@ Static boolean value, always `true`. May be used to distinguish TLS sockets
from regular ones.

### tlsSocket.getCipher()
Returns an object representing the cipher name and the SSL/TLS
protocol version of the current connection.

Returns an object representing the cipher name and the SSL/TLS protocol version
that first defined the cipher.

Example:
{ name: 'AES256-SHA', version: 'TLSv1/SSLv3' }

See SSL_CIPHER_get_name() and SSL_CIPHER_get_version() in
https://www.openssl.org/docs/ssl/ssl.html#DEALING_WITH_CIPHERS for more
https://www.openssl.org/docs/manmaster/ssl/SSL_CIPHER_get_name.html for more
information.

### tlsSocket.getEphemeralKeyInfo()
Expand Down