Skip to content

esm: bypass CJS loader in default load under --default-type=module #50004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2023
Merged

esm: bypass CJS loader in default load under --default-type=module #50004

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2000b1
esm: bypass CJS loader in default load under `--default-type=module`
aduh95 Oct 1, 2023
bd3208a
fixup! esm: bypass CJS loader in default load under `--default-type=m…
aduh95 Oct 1, 2023
fadff3b
fixup! esm: bypass CJS loader in default load under `--default-type=m…
aduh95 Oct 21, 2023
197863a
fixup! esm: bypass CJS loader in default load under `--default-type=m…
aduh95 Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! esm: bypass CJS loader in default load under `--default-type=m… 
…odule`
  • Loading branch information
@aduh95
aduh95 committed Oct 23, 2023
commit 197863a27202bac91dcebeb3ace722a9737c3a03
4 changes: 2 additions & 2 deletions test/es-module/test-esm-type-flag-errors.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ describe('--experimental-default-type=module', { concurrency: true }, () => {
});
});

it('should not affect entry point .cjs files (with no hooks)', async () => {
it('should affect entry point .cjs files (with no hooks)', async () => {
const { stderr, stdout, code } = await spawnPromisified(process.execPath, [
'--experimental-default-type=module',
fixtures.path('es-module-require-cache/echo.cjs'),
]);

strictEqual(stderr, '');
match(stdout, /^\[Object: null prototype\] \{(\n .+)+\n\}\n$/);
match(stdout, /^undefined\n$/);
strictEqual(code, 0);
});

Expand Down