Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ec74b93
doc: remove flicker on page load on dark theme
demakoff Nov 27, 2023
c1ee506
fs: remove workaround for `esm` package
anonrig Nov 27, 2023
eecab88
doc: add doc for Unix abstract socket
theanarkh Nov 28, 2023
94462d4
test: consolidate utf8 text fixtures in tests
joyeecheung Nov 28, 2023
30a6f19
doc: document non-node_modules-only runtime deprecation
joyeecheung Nov 28, 2023
c37d18d
lib: streamline process.binding() handling
joyeecheung Nov 17, 2023
1e40c4a
tools: fix current version check
marco-ippolito Nov 28, 2023
74f5a1c
src: print MKSNAPSHOT debug logs to stderr
joyeecheung Nov 16, 2023
ac3a6ee
test: log more information in SEA tests
joyeecheung Nov 16, 2023
cedc342
doc: run license-builder
github-actions[bot] Nov 29, 2023
759ebca
doc: reserve 121 for Electron 29
codebytere Nov 29, 2023
dc049ac
benchmark: update number of iterations for `util.inspect`
kylo5aby Nov 29, 2023
3faed33
typings: fix JSDoc in `internal/modules/esm/hooks`
himself65 Nov 29, 2023
7adf239
doc: fix some errors in esm resolution algorithms
chjj Nov 29, 2023
4b1bed0
deps: update undici to 5.28.0
nodejs-github-bot Nov 29, 2023
246cf73
lib,src: replace toUSVString with `toWellFormed()`
anonrig Nov 29, 2023
b7036f2
doc: add procedure when CVEs don't get published
RafaelGSS Nov 29, 2023
ca10cbb
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Nov 29, 2023
bed1b93
meta: move one or more collaborators to emeritus
nodejs-github-bot Nov 29, 2023
1cf087d
lib: refactor to use validateFunction in diagnostics_channel
deokjinkim Nov 30, 2023
8e1a70a
tools: add triggers to update release links workflow
MoLow Nov 30, 2023
6a087ce
url: throw error if argument length of revokeObjectURL is 0
DylanTet Nov 30, 2023
3a1c664
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
aparzi Dec 1, 2023
f79b54e
benchmark: update iterations in benchmark/crypto/get-ciphers.js
Dec 2, 2023
9bc7917
loader: speed up line length calc used by moduleProvider
zeusdeux Dec 2, 2023
099ebdb
deps: update undici to 5.28.1
nodejs-github-bot Dec 2, 2023
32acafe
fs: introduce `dirent.parentPath`
aduh95 Dec 2, 2023
b24ee15
benchmark: update iterations in benchmark/crypto/hkdf.js
Dec 3, 2023
7245486
fs: use default w flag for writeFileSync with utf8 encoding
MuriloKakazu Dec 3, 2023
59a45dd
deps: update googletest to b10fad3
nodejs-github-bot Nov 5, 2023
d7c562a
deps: update googletest to 76bb2af
nodejs-github-bot Dec 3, 2023
f6ff11c
src: fix backtrace with tail [[noreturn]] abort
legendecas Dec 3, 2023
1dbe1af
meta: bump github/codeql-action from 2.22.5 to 2.22.8
dependabot[bot] Dec 3, 2023
812ab9e
meta: bump step-security/harden-runner from 2.6.0 to 2.6.1
dependabot[bot] Dec 3, 2023
709ac47
src: disable uncaught exception abortion for ESM syntax detection
anonrig Dec 3, 2023
b281e98
doc: add additional details about `--input-type`
shubham9411 Dec 4, 2023
1e7d101
src: make ModifyCodeGenerationFromStrings more robust
joyeecheung Dec 4, 2023
67ada40
2023-12-05, Version 21.4.0 (Current)
targos Dec 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
url: throw error if argument length of revokeObjectURL is 0
Added a check to see if url wasn't included as an argument
which will then throw an error.

Fixes: #50432
PR-URL: #50433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
  • Loading branch information
DylanTet authored and targos committed Dec 4, 2023
commit 6a087ceffa98ced96654d811048881b93aca49c2
4 changes: 4 additions & 0 deletions lib/internal/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -1108,6 +1108,10 @@ function installObjectURLMethods() {
}

function revokeObjectURL(url) {
if (arguments.length === 0) {
throw new ERR_MISSING_ARGS('url');
}

bindingBlob.revokeObjectURL(`${url}`);
}

Expand Down
14 changes: 14 additions & 0 deletions test/parallel/test-url-revokeobjecturl.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
'use strict';

require('../common');

// Test ensures that the function receives the url argument.

const assert = require('node:assert');

assert.throws(() => {
URL.revokeObjectURL();
}, {
code: 'ERR_MISSING_ARGS',
name: 'TypeError',
});