test: fix flaky test-http-regr-gh-2928 #5154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix flaky test-http-regr-nodejsgh-2928 that has been failing on Raspberry Pi devices in CI. Fixes: nodejs#4830
Member
Author
|
Stress test showing master branch failing frequently: https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/443/console Stress test for this PR: https://ci.nodejs.org/job/node-stress-single-test/450/nodes=pi2-raspbian-wheezy/console |
Member
|
lgtm, I think |
Member
|
Another tentative LGTM. |
Member
|
LGTM |
Member
Author
|
Landed in 2848f84 |
Merged
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.
Fixes: #4830
/cc @indutny
Confirmed (on OS X, anyway) that the test still segmentation faults (as expected/designed) when run with Node 4.1.0 but succeeds with Node 4.1.1.