src: reject per-process isolate flags in workers #53780
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
legendecas
force-pushed
the
env/isolate-flags
branch
from
3f44cb6 to
77adc06
Compare
V8 flags are saved in a per-process storages and were ignored in the Worker constructor options. Reject V8 flags in the Worker constructor proactively to indicate these options should be set at process level.
legendecas
force-pushed
the
env/isolate-flags
branch
from
77adc06 to
2e43ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 flags are saved in a per-process storage and are not effective in the
Worker constructor options (not applied with
V8::SetFlagsFromString).Reject V8 flags in the Worker constructor proactively to indicate these
options should be set at process level.
Refs: #53596