doc: don't require anchor in errors.md
#55283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivkeller
added
doc
aduh95
requested changes
Oct 6, 2024
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
That would break all existing links
Member
Author
|
I built the docs and checked - it doesn't, as the anchors are already generated from the headers |
Contributor
|
What about links on e.g. StackOverflow? |
Member
Author
|
I'll look into that 👀 |
Member
Author
|
When search for pages linking to the error docs, I couldn't find any that included a |
avivkeller
force-pushed
the
no-anchor-errors
branch
from
f4e88f9 to
90f27a9
Compare
aduh95
requested changes
Oct 9, 2024
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
RedYetiDev requested a review from aduh95
As said before, I'm -1 on that as it breaks all existing links (not in our control), and does not improve anything AFAICT.
Member
Author
|
I understand, I'll close this. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested it, and the anchors aren't needed, as the headers themselves generate anchors:
