Skip to content

build: build v8 with -fvisibility=hidden on macOS #56275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

build: build v8 with -fvisibility=hidden on macOS #56275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b1bdd4
build: build v8 with -fvisibility=hidden on macOS
joyeecheung Dec 16, 2024
3ee4021
fixup! build: build v8 with -fvisibility=hidden on macOS
joyeecheung Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@
'AdditionalOptions': ['/utf-8']
}
},
'conditions': [
['OS=="mac"', {
# Hide symbols that are not explicitly exported with V8_EXPORT.
# TODO(joyeecheung): enable it on other platforms. Currently gcc times out
# or run out of memory with -fvisibility=hidden on some machines in the CI.
'xcode_settings': {
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
},
'defines': [
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
],
}],
],
},
'targets': [
{
Expand Down
Loading