Skip to content

tools: fix vcbuild test when path contain spaces #56481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

tools: fix vcbuild test when path contain spaces #56481

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a4087c
tools: fix `vcbuild test` when path contain spaces
stduhpf Jan 5, 2025
c33319c
tools: fix vcbuild test whith consistent syntax
stduhpf Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools: fix vcbuild test whith consistent syntax 
Co-authored-by: Luigi Pinca <[email protected]>
  • Loading branch information
@stduhpf @lpinca
stduhpf and lpinca authored Jan 5, 2025
commit c33319ce668cde3fa6280cf1ba6bfaf90c1d0c1e
2 changes: 1 addition & 1 deletion vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ if defined package set stage_package=1
:: assign path to node_exe
set "node_exe=%config%\node.exe"
set "node_gyp_exe="%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp"
set "npm_exe="%~dp0%node_exe%" "%~dp0deps\npm\bin\npm-cli.js""
set "npm_exe="%node_exe%" deps\npm\bin\npm-cli.js"
if "%target_env%"=="vs2022" set "node_gyp_exe=%node_gyp_exe% --msvs_version=2022"

:: skip building if the only argument received was lint
Expand Down
Loading