Skip to content

readline: add stricter validation for functions called after closed #57680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

readline: add stricter validation for functions called after closed #57680

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a34766a
readline: add stricter validation for functions called after closed
dario-piotrowicz Mar 29, 2025
6ef6024
Update test/parallel/test-repl-import-referrer.js
dario-piotrowicz Apr 4, 2025
917ecbe
increase timeout
dario-piotrowicz Apr 5, 2025
64b9744
add delays to `setTimeout`s
dario-piotrowicz Apr 6, 2025
78e0c38
avoid `setTimeout` in `test-repl-import-referrer.js`
dario-piotrowicz Apr 6, 2025
c5cae2e
remove `setTimeout` calls (by replacing `rli.close()` with `fi.end()`)
dario-piotrowicz Apr 6, 2025
242de21
test that no `resume` nor `pause` events get emitted
dario-piotrowicz Apr 6, 2025
e388d3b
move `process.stdin.unref` call inside `setupHistory` callback
dario-piotrowicz Apr 11, 2025
d46db9f
hopefully address ci failure in test-repl-uncaught-exception-async.js
dario-piotrowicz Apr 12, 2025
425b7db
remove extra spaces
dario-piotrowicz Apr 12, 2025
f5a038b
Revert "move `process.stdin.unref` call inside `setupHistory` callback"
dario-piotrowicz Apr 12, 2025
cd44076
hopefully address ci failure in test-repl-no-terminal.js
dario-piotrowicz Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "move process.stdin.unref call inside setupHistory callback" 
This reverts commit e388d3b.

Note: it didn't really solve the CI issue unfortunately
  • Loading branch information
@dario-piotrowicz
dario-piotrowicz committed Apr 12, 2025
commit f5a038b7472fd4ff281da6da283c7998302538fc
5 changes: 2 additions & 3 deletions test/parallel/test-repl-no-terminal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ const common = require('../common');

const repl = require('repl');
const r = repl.start({ terminal: false });
r.setupHistory('/nonexistent/file', common.mustSucceed(() => {
process.stdin.unref?.();
}));
r.setupHistory('/nonexistent/file', common.mustSucceed());
process.stdin.unref?.();