Skip to content

lib: deprecate _http_* #58535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

lib: deprecate _http_* #58535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6335e0
lib: deprecate _http_*
bjohansebas May 31, 2025
e6a2193
test: update internal module references and add flags for tests
bjohansebas May 31, 2025
cdce873
http,http2,https: use http internals
bjohansebas May 31, 2025
5b223df
test: add test for warnings
bjohansebas May 31, 2025
bd305a8
benchmack: no use internals
bjohansebas May 31, 2025
2103d6f
Update test/parallel/test-warn-http-server-deprecation.js
bjohansebas May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmack: no use internals
  • Loading branch information
@bjohansebas
bjohansebas authored May 31, 2025
commit bd305a8caf85e954bb6c69d6ec7010db6d3800b8
1 change: 1 addition & 0 deletions benchmark/http/check_invalid_header_char.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common.js');
// TODO: benchmark has access to internal modules?
Copy link
Member

@dario-piotrowicz dario-piotrowicz May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the require be updated to internal/http/common? 🙂

Copy link
Member Author

@bjohansebas bjohansebas May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but I’m not really sure if the benchmark has access to the internals or not :)

Copy link
Member

@dario-piotrowicz dario-piotrowicz Jun 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no.... the benchmarks, as far as I understand it, should be runnable with any build of node, so yeah that's a good point, I don't think it's correct to have a benchmark access internal modules

const _checkInvalidHeaderChar = require('_http_common')._checkInvalidHeaderChar;

const groupedInputs = {
Expand Down
1 change: 1 addition & 0 deletions benchmark/http/check_is_http_token.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common.js');
// TODO: benchmark has access to internal modules?
const _checkIsHttpToken = require('_http_common')._checkIsHttpToken;
Copy link
Member

@jasnell jasnell May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't really considered internal modules, fwiw

Copy link
Member Author

@bjohansebas bjohansebas May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that property is not under the http module, so when _http_common stops being a module and becomes internal-only, the benchmark won’t work. That’s why I was asking if it's possible to use internals in the benchmarks.

Copy link
Member

@dario-piotrowicz dario-piotrowicz May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I imagine that the require was supposed to be updated to internal/http/common?

Copy link
Member

@jasnell jasnell Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern would be whether or not anyone in userland could be using this, as unlikely as that may be. Should we export this through the regular node:http API to provide an alternative path to them?


const bench = common.createBenchmark(main, {
Expand Down
2 changes: 1 addition & 1 deletion benchmark/http/set_header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const common = require('../common.js');
const { OutgoingMessage } = require('_http_outgoing');
const { OutgoingMessage } = require('http');

const bench = common.createBenchmark(main, {
value: [
Expand Down
Loading