Skip to content

Conversation

@mertcanaltin
Copy link
Member

I defined array type to prevent buffer overflow

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 4, 2025
@mertcanaltin mertcanaltin force-pushed the mert/added-array-type branch from 13b33c1 to bc9840a Compare June 4, 2025 21:46
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (641653b) to head (bc9840a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58581      +/-   ##
==========================================
- Coverage   90.21%   90.19%   -0.02%     
==========================================
  Files         635      635              
  Lines      187494   187494              
  Branches    36838    36818      -20     
==========================================
- Hits       169144   169108      -36     
- Misses      11145    11169      +24     
- Partials     7205     7217      +12     
Files with missing lines Coverage Δ
src/node_contextify.cc 81.27% <100.00%> (ø)

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
Copy link
Member

jasnell commented Jun 4, 2025

Won't block but also don't think this is really all that valuable.

@mertcanaltin
Copy link
Member Author

Won't block but also don't think this is really all that valuable.

I get it, I thought it would secure the type.

I will close this place as it will not contribute, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants