Skip to content

module: correctly detect top-level await in ambiguous contexts #58646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 15, 2025
Merged

module: correctly detect top-level await in ambiguous contexts #58646

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d805a1
module: correctly detect top-level await in ambiguous contexts
islandryu Jun 9, 2025
a8a3a33
use std::array
islandryu Jun 10, 2025
9d6a322
move test
islandryu Jun 16, 2025
c4f371b
fix format
islandryu Jun 22, 2025
2b3000c
add test for unrelated error
islandryu Jun 29, 2025
a60b3e0
undo a test that has been erased
islandryu Jun 29, 2025
e65cc6c
fix lint
islandryu Jun 29, 2025
993bcfc
Update test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tl…
islandryu Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use std::array
  • Loading branch information
@islandryu
islandryu committed Jun 29, 2025
commit a8a3a33e3b162ea93e535fe28bba907560fcf9c1
10 changes: 5 additions & 5 deletions src/node_contextify.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1647,11 +1647,11 @@ static const auto throws_only_in_cjs_error_messages =
"await is only valid in async functions and "
"the top level bodies of modules"};

static std::vector<std::string_view> maybe_top_level_await_errors = {
// example: `func(await 1);`
"missing ) after argument list",
// example: `if(await 1)`
"SyntaxError: Unexpected"};
static const auto maybe_top_level_await_errors =
std::array<std::string_view, 2>{// example: `func(await 1);`
"missing ) after argument list",
// example: `if(await 1)`
"SyntaxError: Unexpected"};
Copy link
Member

@jasnell jasnell Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the linter/formatter format the code this way?

Copy link
Member Author

@islandryu islandryu Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but now that you mention it, it's a weird format.
I've changed the comment's position.

Copy link
Member Author

@islandryu islandryu Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell
Could you take another look when you have a moment?


// If cached_data is provided, it would be used for the compilation and
// the on-disk compilation cache from NODE_COMPILE_CACHE (if configured)
Expand Down