Skip to content

lib: add support for readable byte streams to .toWeb() #58664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 14 commits into from
Nov 16, 2025
Merged

lib: add support for readable byte streams to .toWeb() #58664

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c5c4351
lib: add support for readable byte streams to .toWeb()
seriousme Jun 10, 2025
ca0aa34
fix: correct link from webstream to streamduplextowebstreamduplex
seriousme Jun 14, 2025
b9e395a
rewrite of test-stream-readable-to-web-byob.js
seriousme Jun 16, 2025
814af3b
add validation of 'type' option
seriousme Jun 16, 2025
e9cca53
use internal validators to validate options
seriousme Jun 16, 2025
36050d8
Update lib/internal/webstreams/adapters.js
seriousme Jun 17, 2025
385f3fc
add item to doc changes
seriousme Jun 21, 2025
1e82627
applied various changes
seriousme Jun 21, 2025
8f475bd
fixed test-stream-readable-to-web-byob.js
seriousme Jun 27, 2025
7efa8d2
applied review changes to adapters.js
seriousme Jun 27, 2025
ffcf924
remove colon from description as it breaks the YAML
seriousme Jul 6, 2025
8612c1e
add single quotes to 'type'
seriousme Jul 6, 2025
f9e4a86
update stream.md
seriousme Jul 9, 2025
55af65e
Apply suggestions from code review by jasnell
seriousme Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add item to doc changes
  • Loading branch information
@seriousme
seriousme committed Jul 10, 2025
commit 385f3fc4343e26ac9493ded054f1d8329e595e07
4 changes: 3 additions & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3179,6 +3179,9 @@ Returns whether the stream has been read from or cancelled.
<!-- YAML
added: v17.0.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/58664
description: add {type: 'bytes'} option
- version:
- v24.0.0
- v22.17.0
Expand All @@ -3202,7 +3205,6 @@ changes:
* `chunk` {any}
* Returns: {number}
* `type` {string} Must be 'bytes' or undefined.
If `type` is set to 'bytes', the `strategy` option is ignored
* Returns: {ReadableStream}

### `stream.Writable.fromWeb(writableStream[, options])`
Expand Down