Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
d596803
doc: add path rules and validation for export targets in package.json
0hmX Jun 9, 2025
893999e
src: replace V8 Fast API todo comment with note comment
dario-piotrowicz Jun 9, 2025
a4d7560
test: close FileHandle objects in tests explicitly
jasnell Jun 9, 2025
713fbad
test_runner: support object property mocking
idango10 Jun 9, 2025
4347ce3
src: add new CopyUtimes function to reduce code duplication
dario-piotrowicz Jun 9, 2025
dc10238
deps: update zlib to 1.3.1-470d3a2
nodejs-github-bot Jun 10, 2025
80eac14
deps: update simdjson to 3.13.0
nodejs-github-bot Jun 10, 2025
3aa2762
deps: update sqlite to 3.50.1
nodejs-github-bot Jun 10, 2025
181014a
test: cleanup status files
panva Jun 10, 2025
e9c6fa5
src: replace std::array with static arrays in contextify
mertcanaltin Jun 10, 2025
85f062c
test: deflake async-hooks/test-improper-order on AIX
bakigul1 Jun 3, 2025
7e34aa4
test: skip tests failing when run under root
LiviaMedeiros Jun 10, 2025
839964e
fs: allow correct handling of burst in fs-events with AsyncIterator
pipobscure Jun 10, 2025
450f481
deps: update amaro to 1.0.0
nodejs-github-bot Jun 11, 2025
76e3c8a
test: update WPT for es-exceptions to 2f96fa1996
nodejs-github-bot Jun 11, 2025
aa657f0
test: split indirect eval import tests
legendecas Jun 11, 2025
a3c7a63
module: allow cycles in require() in the CJS handling in ESM loader
joyeecheung Jun 11, 2025
9b28f40
module: remove experimental warning from type stripping
marco-ippolito Jun 11, 2025
fa089d6
test: update WPT for dom/abort to dc928169ee
nodejs-github-bot Jun 11, 2025
94e53d4
test: update WPT for urlpattern to 3ffda23e5a
nodejs-github-bot Jun 1, 2025
b1f60d2
http2: add diagnostics channel 'http2.server.stream.close'
RaisinTen Jun 11, 2025
b11da11
http2: fix DEP0194 message
climba03003 Jun 11, 2025
afbaf92
tools: improve release proposal linter
aduh95 Jun 11, 2025
6390f70
lib,src: support DOMException ser-des
legendecas Jun 11, 2025
b6760b3
esm: syncify default path of `ModuleLoader.load`
JakobJingleheimer Jun 11, 2025
ffff8ce
typings: add ZSTD_COMPRESS, ZSTD_DECOMPRESS to internalBinding
nektro Jun 12, 2025
45f7d16
module: refactor commonjs typescript loader
marco-ippolito Jun 12, 2025
ff8a369
module: fix typescript import.meta.main
marco-ippolito Jun 12, 2025
c1f9791
tools: edit commit-queue workflow file
aduh95 Jun 12, 2025
1cc77c7
doc: punctuation fix for Node-API versioning clarification
jiacai2050 Jun 12, 2025
268c8c1
tools: remove config.status under `make distclean`
Renegade334 Jun 12, 2025
b22e970
tools: switch to `@stylistic/eslint-plugin`
targos Jun 13, 2025
ec808b3
test: use `common.skipIfInspectorDisabled()` to skip tests
dario-piotrowicz Jun 13, 2025
dfb0144
src: enhance error messages for unknown options
pmarchini Jun 13, 2025
e6a1787
tools: bump brace-expansion from 1.1.11 to 1.1.12 in /tools/eslint
dependabot[bot] Jun 14, 2025
dc2f23e
tools: bump `brace-expansion` in `/tools/clang-format`
dependabot[bot] Jun 14, 2025
ef0230a
url: add fileURLToPathBuffer API
jasnell Jun 12, 2025
b7e488c
test: refactor repl tab complete tests
dario-piotrowicz Jun 15, 2025
c39d570
test: reduce the use of private symbols in test-events-once.js
kt3k Jun 15, 2025
17df800
typings: add Atomics primordials
Renegade334 Jun 4, 2025
704b1fa
test: add tests for REPL custom evals
dario-piotrowicz Jun 15, 2025
841609a
doc: add islandryu to collaborators
islandryu Jun 16, 2025
fb4378b
fs: add UV_ENOSPC to list of things to pass to err directly
jackyzha0 Jun 16, 2025
6f7b895
util: inspect: do not crash on an Error stack pointing to itself
SamVerschueren Jun 16, 2025
82b18ba
repl: fix tab completion not working with computer string properties
dario-piotrowicz Jun 17, 2025
c9e7b5e
test_runner: prefer `Atomics` primordials
Renegade334 Jun 4, 2025
af18c0e
fs: remove IIFE in glob
LiviaMedeiros May 21, 2025
f125310
doc: run license-builder
github-actions[bot] Jun 18, 2025
62b5879
fs: avoid computing time coefficient constants in runtime
LiviaMedeiros Jun 18, 2025
7bb1246
doc: add history entry for TS support in hooks
aduh95 Jun 18, 2025
d94b184
test: deflake test-buffer-large-size-buffer-alloc
lpinca Jun 18, 2025
68671f4
deps: upgrade npm to 11.4.2
npm-cli-bot Jun 20, 2025
6e0ee39
test: skip the test if the buffer allocation fails
lpinca Jun 20, 2025
b5ff3f4
tools: include toolchain.gypi in abseil.gyp
legendecas Jun 20, 2025
be93091
inspector: add protocol methods retrieving sent/received data
legendecas Jun 20, 2025
e2e88d4
doc: fix wrong RFC number in http2
deokjinkim Jun 20, 2025
fa6854f
deps: update amaro to 1.1.0
nodejs-github-bot Jun 20, 2025
96c78d7
fs: make `Dir` disposers idempotent
Renegade334 Jun 20, 2025
4b61f10
deps: V8: cherry-pick e3df60f3f5ab
legendecas Jun 19, 2025
081c708
lib: make domexception a native error
legendecas Jun 12, 2025
a0b1378
src: pass resource on permission checks for spawn
RafaelGSS Jun 21, 2025
8eec789
test: correct SIMD support comment
richardlau Jun 21, 2025
9df1cfe
tools: make nodedownload module compatible with Python 3.14
frenzymadness Jun 22, 2025
3faa4e8
test: deflake test-buffer-large-size-buffer-alloc-unsafe
lpinca Jun 22, 2025
d9c2b70
test: refactor repl save-load tests
dario-piotrowicz Jun 22, 2025
d0e42ff
repl: avoid deprecated `require.extensions` in tab completion
gulbaki Jun 23, 2025
6ef7329
Revert "test_runner: automatically wait for subtests to finish"
romainmenke May 11, 2025
8b0c5ed
Revert "test_runner: remove promises returned by test()"
romainmenke May 11, 2025
dce1995
Revert "test_runner: remove promises returned by t.test()"
romainmenke May 11, 2025
7cdda92
test: fix test-timeout-flag after revert of auto subtest wait
pmarchini May 14, 2025
4703ef2
2025-06-24, Version 24.3.0 (Current)
nodejs-github-bot Jun 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix test-timeout-flag after revert of auto subtest wait
PR-URL: #58282
Fixes: #58227
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
  • Loading branch information
pmarchini authored and RafaelGSS committed Jun 23, 2025
commit 7cdda927fa8244f379c4d98f99af8d10f8d8c4a9
40 changes: 30 additions & 10 deletions test/fixtures/test-runner/output/test-timeout-flag.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,39 @@
// Flags: --test-timeout=20
'use strict';
const { describe, test } = require('node:test');
const { setTimeout } = require('node:timers/promises');
const { describe, it, after } = require('node:test');
const { setTimeout } = require('node:timers');

const timeoutRefs = [];

describe('--test-timeout is set to 20ms', () => {
test('should timeout after 20ms', async () => {
await setTimeout(200000, undefined, { ref: false });
it('should timeout after 20ms', async () => {
const { promise, resolve } = Promise.withResolvers();
timeoutRefs.push(setTimeout(() => {
resolve();
}, 20000));
await promise;
});
test('should timeout after 5ms', { timeout: 5 }, async () => {
await setTimeout(200000, undefined, { ref: false });

it('should timeout after 5ms', { timeout: 5 }, async () => {
const { promise, resolve } = Promise.withResolvers();
timeoutRefs.push(setTimeout(() => {
resolve();
}, 20000));
await promise;
});

test('should not timeout', { timeout: 50000 }, async () => {
await setTimeout(1);
it('should not timeout', { timeout: 50000 }, async () => {
const { promise, resolve } = Promise.withResolvers();
timeoutRefs.push(setTimeout(() => {
resolve();
}, 1));
await promise;
});

test('should pass', async () => {});
it('should pass', async () => {});

after(() => {
for (const timeoutRef of timeoutRefs) {
clearTimeout(timeoutRef);
}
});
});
11 changes: 9 additions & 2 deletions test/parallel/test-runner-output.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,19 @@ const tests = [
},
{
name: 'test-runner/output/test-timeout-flag.js',
flags: ['--test-reporter=tap'],
flags: [
'--test-reporter=tap',
'--test-timeout=20',
],
},
// --test-timeout should work with or without --test flag
{
name: 'test-runner/output/test-timeout-flag.js',
flags: ['--test-reporter=tap', '--test'],
flags: [
'--test-reporter=tap',
'--test-timeout=20',
'--test',
],
},
{
name: 'test-runner/output/hooks-with-no-global-test.js',
Expand Down
Loading