Skip to content

Conversation

@mertcanaltin
Copy link
Member

add memory tracking for secureContext openssl objects

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 13, 2025
@codecov
Copy link

codecov bot commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (049664b) to head (e8f94f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59051      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.01%     
==========================================
  Files         645      645              
  Lines      189130   189134       +4     
  Branches    37094    37093       -1     
==========================================
- Hits       170339   170332       -7     
+ Misses      11511    11503       -8     
- Partials     7280     7299      +19     
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 69.31% <100.00%> (+0.15%) ⬆️
src/crypto/crypto_context.h 100.00% <ø> (ø)
src/crypto/crypto_util.h 75.61% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants