Skip to content

quic: fixup windows coverage compile error #59381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

quic: fixup windows coverage compile error #59381

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26a7df8
quic: fixup windows coverage compile error
jasnell Aug 6, 2025
6b3ac3f
quic: fixup NO_ERROR macro conflict on windows
jasnell Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/quic/data.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,15 +149,15 @@ T Store::convert() const {
}

Store::operator uv_buf_t() const {
return convert<uv_buf_t, typeof(*uv_buf_t::base)>();
return convert<uv_buf_t, char>();
}

Store::operator ngtcp2_vec() const {
return convert<ngtcp2_vec, typeof(*ngtcp2_vec::base)>();
return convert<ngtcp2_vec, uint8_t>();
}

Store::operator nghttp3_vec() const {
return convert<nghttp3_vec, typeof(*ngtcp2_vec::base)>();
return convert<nghttp3_vec, uint8_t>();
}

void Store::MemoryInfo(MemoryTracker* tracker) const {
Expand Down
Loading