Skip to content

[v24.x] lib: do not modify prototype deprecated asyncResource (encore) #59518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[v24.x] lib: do not modify prototype deprecated asyncResource (encore) #59518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: do not modify prototype deprecated asyncResource (encore) 
Previous attempt has missed one argument (`useEmitSync`), therefore it
effectively did not work as intended.

This change sets `useEmitSync` to `false` which is equivalent to
previous behaviour of `undefined` and sets `modifyPrototype` to `false`
as expected.

Refs: #58218
Refs: #59195
  • Loading branch information
@slagiewka
slagiewka committed Aug 26, 2025
commit f0329933755bb5f935fe00a1d577ebdf412465dc
4 changes: 2 additions & 2 deletions lib/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,10 @@ class AsyncResource {
enumerable: true,
get: deprecate(function() {
return self;
}, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false),
}, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false, false),
set: deprecate(function(val) {
self = val;
}, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false),
}, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false, false),
},
});
return bound;
Expand Down
Loading