Skip to content

repl: fix wrong parentheses #59607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 27, 2025
Merged

repl: fix wrong parentheses #59607

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f146e9c
repl: add isValidParentheses check before wrap input
jenthone Mar 6, 2023
334b186
test: add Uncaught ReferenceError case
jenthone Mar 7, 2023
e367980
test: add Uncaught SyntaxError case
jenthone Mar 7, 2023
73e23c8
test: add SyntaxError: Unexpected token case
jenthone Mar 7, 2023
c20260e
repl: check valid syntax by using acorn
jenthone Mar 8, 2023
94cad39
test: add open bracket case
jenthone Mar 8, 2023
13b2c53
repl: try parse again and allowAwaitOutsideFunction
jenthone Mar 9, 2023
814248a
test: add string-keyed object case
jenthone Mar 9, 2023
953874e
test: add more bracket cases
jenthone Mar 9, 2023
0230e45
test: add multiple object case
jenthone Mar 9, 2023
6093854
repl: add isValidParentheses check before wrap input
meixg Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add Uncaught SyntaxError case
  • Loading branch information
@jenthone @meixg
jenthone authored and meixg committed Aug 24, 2025
commit e367980ab4eb5a651761ae76c52ed4efd179d70c
19 changes: 17 additions & 2 deletions test/parallel/test-repl-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,16 @@ async function tests(options) {
'aaaa\r',
'Uncaught ReferenceError: aaaa is not defined'
]
}, {
input: '/0',
noPreview: '/0',
preview: [
'/0\r',
'/0',
'^',
'',
'Uncaught SyntaxError: Invalid regular expression: missing /',
]
}];

const hasPreview = repl.terminal &&
Expand All @@ -184,8 +194,13 @@ async function tests(options) {
assert.deepStrictEqual(lines, preview);
} else {
assert.ok(lines[0].includes(noPreview), lines.map(inspect));
if (preview.length !== 1 || preview[0] !== `${input}\r`)
assert.strictEqual(lines.length, 2);
if (preview.length !== 1 || preview[0] !== `${input}\r`) {
if (preview[preview.length-1].includes('Uncaught SyntaxError')) { // Syntax error
assert.strictEqual(lines.length, 5);
} else {
assert.strictEqual(lines.length, 2);
}
}
}
}
}
Expand Down