Skip to content

typings: update 'types' binding #59692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

typings: update 'types' binding #59692

merged 1 commit into from
Sep 24, 2025
+33 −30

Conversation

@Renegade334
Copy link
Contributor

@Renegade334 Renegade334 commented Aug 31, 2025

  • Add missing methods:
    • isGeneratorObject
    • isProxy
    • isSharedArrayBuffer
    • isSymbolObject
  • Remove non-extant methods:
    • isTypedArray
  • Fix bad predicates:
    • isDate, isNativeError, isRegExp
      • These were previously declared to return the type itself, not a predicate.
  • Improvements to predicate types:
    • isArgumentsObject
      • TypeScript provides IArguments to describe the built-in arguments object.
    • isExternal
      • In TypeScript, object is the non-primitive object type. Object resolves to any value that is not null or undefined.

These definitions remain compatible with TS 3.9+, as before.

Also sorts the macro list in node_types.cc and matches the ordering in types.d.ts to the source, for ease of maintenance.

@Renegade334
typings: update 'types' binding
d1468d6 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings labels Aug 31, 2025
@codecov
Copy link

codecov bot commented Aug 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (f36de72) to head (d1468d6).
⚠️ Report is 169 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59692      +/-   ##
==========================================
+ Coverage   89.86%   89.91%   +0.05%     
==========================================
  Files         667      667              
  Lines      196792   196792              
  Branches    38632    38414     -218     
==========================================
+ Hits       176842   176945     +103     
+ Misses      12370    12266     -104     
- Partials     7580     7581       +1
Files with missing lines Coverage Δ
src/node_types.cc 94.87% <ø> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 1, 2025
@BridgeAR BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 14, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69228/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 23, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69335/

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit e4e86ea into nodejs:main Sep 24, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2025

Landed in e4e86ea

@Renegade334 Renegade334 deleted the types-binding-typings branch September 24, 2025 17:21
targos pushed a commit that referenced this pull request Oct 6, 2025
@Renegade334 @targos
typings: update 'types' binding
275c070 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal

PR-URL: #59692
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
@Renegade334 @aduh95
typings: update 'types' binding
1f681ad 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal

PR-URL: #59692
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
@Renegade334 @aduh95
typings: update 'types' binding
ef005d0 
- Adds:
  - isGeneratorObject
  - isProxy
  - isSharedArrayBuffer
  - isSymbolObject
- Removes:
  - isTypedArray
- Fixes:
  - isDate
  - isNativeError
  - isRegExp
- Improves:
  - isArgumentsObject
  - isExternal

PR-URL: #59692
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@daeyeon daeyeon daeyeon approved these changes

@legendecas legendecas legendecas approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Renegade334 @nodejs-github-bot @jasnell @daeyeon @legendecas @BridgeAR @addaleax