http: perf improvements #59855
Open
http: perf improvements #59855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59855 +/- ##
==========================================
- Coverage 89.93% 88.26% -1.68%
==========================================
Files 669 702 +33
Lines 197540 206687 +9147
Branches 38599 39754 +1155
==========================================
+ Hits 177657 182425 +4768
- Misses 12296 16284 +3988
- Partials 7587 7978 +391
🚀 New features to boost your workflow:
|
RafaelGSS
requested changes
Sep 11, 2025
There was a problem hiding this comment.
It seems no performance improvement. Ref: https://openjs-foundation.slack.com/archives/C049LSE8QBH/p1757601951692649?thread_ts=1757599942.319249&cid=C049LSE8QBH
jasnell
reviewed
Sep 13, 2025
|
|
||
| state.incoming.shift(); | ||
| if (head !== null && head !== req) { | ||
| throw new Error('Out of order response finish'); |
There was a problem hiding this comment.
Needs a proper node.js error with a code property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.