vm: make vm.Module.evaluate() conditionally synchronous #60205

joyeecheung · 2025-10-10T18:24:05Z

This patch:

Make sure that the vm.Module.evaluate() method is conditionally synchronous based on the specification. Previously, it's unconditionally asynchronous (even for synthetic modules and source text modules without top-level await).
Clarify the synchronicity of this method in the documentation
Add more tests for the synchronicity of this method.

codecov · 2025-10-10T19:20:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (db0121b) to head (6cdd4dc).
⚠️ Report is 61 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60205      +/-   ##
==========================================
+ Coverage   88.53%   88.57%   +0.03%     
==========================================
  Files         704      704              
  Lines      208087   208328     +241     
  Branches    40010    40033      +23     
==========================================
+ Hits       184239   184518     +279     
+ Misses      15866    15854      -12     
+ Partials     7982     7956      -26

Files with missing lines	Coverage Δ
lib/internal/vm/module.js	`96.37% <100.00%> (+0.03%)`	⬆️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

doc/api/vm.md

test/parallel/test-vm-module-evaluate-source-text-module.js

lib/internal/vm/module.js

test/parallel/test-vm-module-evaluate-source-text-module.js

joyeecheung · 2025-10-12T17:49:30Z

Added a benchmark for source text modules - there are some performance improvements by removing the async-await:

                                                                      confidence improvement accuracy (*)    (**)   (***)
vm/source-text-module-leaf.js n=1000 type='async' stage='all'                ***      4.24 %       ±2.05%  ±2.72%  ±3.55%
vm/source-text-module-leaf.js n=1000 type='async' stage='compile'                    -0.58 %       ±1.54%  ±2.05%  ±2.68%
vm/source-text-module-leaf.js n=1000 type='async' stage='evaluate'           ***     31.67 %       ±8.54% ±11.40% ±14.91%
vm/source-text-module-leaf.js n=1000 type='async' stage='instantiate'                 6.96 %       ±8.02% ±10.68% ±13.90%
vm/source-text-module-leaf.js n=1000 type='async' stage='link'                        1.29 %       ±2.93%  ±3.92%  ±5.15%
vm/source-text-module-leaf.js n=1000 type='sync' stage='all'                   *      1.28 %       ±1.06%  ±1.42%  ±1.85%
vm/source-text-module-leaf.js n=1000 type='sync' stage='compile'                     -0.97 %       ±1.32%  ±1.76%  ±2.29%
vm/source-text-module-leaf.js n=1000 type='sync' stage='evaluate'            ***     15.50 %       ±3.84%  ±5.11%  ±6.65%
vm/source-text-module-leaf.js n=1000 type='sync' stage='instantiate'                  3.47 %       ±4.66%  ±6.21%  ±8.08%
vm/source-text-module-leaf.js n=1000 type='sync' stage='link'                        -1.68 %       ±2.83%  ±3.80%  ±5.01%

- Make sure that the vm.Module.evaluate() method is conditionally synchronous based on the specification. Previously, the returned promise is unconditionally pending (even for synthetic modules and source text modules without top-level await) instead of immediately fulfilled, making it harder to debug as it deviates from the specified behavior. - Clarify the synchronicity of this method in the documentation - Add more tests for the synchronicity of this method.

joyeecheung · 2025-10-13T10:32:00Z

Updated the evaluate implementation so that it keeps rejecting for loader errors yet still returns an immediately fulfilled promise for the actual evaluation. The perf numbers are still similar:

                                                                      confidence improvement accuracy (*)    (**)   (***)
vm/source-text-module-leaf.js n=1000 type='async' stage='all'                ***      3.81 %       ±1.19%  ±1.59%  ±2.07%
vm/source-text-module-leaf.js n=1000 type='async' stage='compile'                    -0.85 %       ±1.11%  ±1.48%  ±1.93%
vm/source-text-module-leaf.js n=1000 type='async' stage='evaluate'           ***     34.00 %       ±8.05% ±10.74% ±14.02%
vm/source-text-module-leaf.js n=1000 type='async' stage='instantiate'                -1.24 %       ±7.81% ±10.40% ±13.54%
vm/source-text-module-leaf.js n=1000 type='async' stage='link'                       -0.58 %       ±2.57%  ±3.44%  ±4.51%
vm/source-text-module-leaf.js n=1000 type='sync' stage='all'                          0.67 %       ±1.27%  ±1.70%  ±2.21%
vm/source-text-module-leaf.js n=1000 type='sync' stage='compile'                     -0.24 %       ±1.12%  ±1.49%  ±1.94%
vm/source-text-module-leaf.js n=1000 type='sync' stage='evaluate'            ***     19.77 %       ±3.54%  ±4.72%  ±6.14%
vm/source-text-module-leaf.js n=1000 type='sync' stage='instantiate'                  1.93 %       ±4.66%  ±6.20%  ±8.07%
vm/source-text-module-leaf.js n=1000 type='sync' stage='link'                        -0.09 %       ±3.83%  ±5.09%  ±6.63%

joyeecheung · 2025-10-13T10:42:48Z

Opened a separate issue about the rejection #60242

nodejs-github-bot · 2025-10-13T15:35:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69713/

nodejs-github-bot · 2025-10-14T16:13:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69725/

doc/api/vm.md

…#60205 Co-authored-by: Chengzhong Wu <[email protected]>

Co-authored-by: Chengzhong Wu <[email protected]>

nodejs-github-bot · 2025-10-15T11:36:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69735/

nodejs-github-bot · 2025-10-15T19:47:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69743/

joyeecheung · 2025-10-16T12:05:23Z

CI is green. Can you take a look again? Thanks! @legendecas

doc/api/vm.md

nodejs-github-bot · 2025-10-16T15:50:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69762/

nodejs-github-bot · 2025-10-17T10:54:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69772/

nodejs-github-bot · 2025-10-17T13:09:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69778/

nodejs-github-bot · 2025-10-17T16:29:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69790/

nodejs-github-bot · 2025-10-17T21:28:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69797/

nodejs-github-bot · 2025-10-18T08:07:28Z

Commit Queue failed

- Loading data for nodejs/node/pull/60205 ✔ Done loading data for nodejs/node/pull/60205 ----------------------------------- PR info ------------------------------------ Title vm: make vm.Module.evaluate() conditionally synchronous (#60205) Author Joyee Cheung <[email protected]> (@joyeecheung) Branch joyeecheung:vm-evaluate -> nodejs:main Labels vm, needs-ci Commits 4 - benchmark: add benchmark for leaf source text modules - vm: make vm.Module.evaluate() conditionally synchronous - fixup! vm: make vm.Module.evaluate() conditionally synchronous - fixup! vm: make vm.Module.evaluate() conditionally synchronous Committers 2 - Joyee Cheung <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60205 Refs: https://github.com/nodejs/node/issues/59656 Refs: https://github.com/nodejs/node/issues/37648 Reviewed-By: Chengzhong Wu <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60205 Refs: https://github.com/nodejs/node/issues/59656 Refs: https://github.com/nodejs/node/issues/37648 Reviewed-By: Chengzhong Wu <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 10 Oct 2025 18:24:05 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/60205#pullrequestreview-3349984784 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-10-17T21:28:01Z: https://ci.nodejs.org/job/node-test-pull-request/69797/ - Querying data for job/node-test-pull-request/69797/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60205 From https://github.com/nodejs/node * branch refs/pull/60205/merge -> FETCH_HEAD ✔ Fetched commits as 4d1dece375a2..6cdd4dcc958a -------------------------------------------------------------------------------- [main 07f63a17a0] benchmark: add benchmark for leaf source text modules Author: Joyee Cheung <[email protected]> Date: Sun Oct 12 19:47:58 2025 +0200 1 file changed, 84 insertions(+) create mode 100644 benchmark/vm/source-text-module-leaf.js Auto-merging doc/api/vm.md [main 95f292728c] vm: make vm.Module.evaluate() conditionally synchronous Author: Joyee Cheung <[email protected]> Date: Fri Oct 10 20:20:09 2025 +0200 6 files changed, 390 insertions(+), 30 deletions(-) create mode 100644 test/parallel/test-vm-module-evaluate-source-text-module.js create mode 100644 test/parallel/test-vm-module-evaluate-synthethic-module-rejection.js create mode 100644 test/parallel/test-vm-module-evaluate-synthethic-module.js create mode 100644 test/parallel/test-vm-module-evaluate-while-evaluating.js Auto-merging doc/api/vm.md [main d9563420ba] fixup! vm: make vm.Module.evaluate() conditionally synchronous Author: Joyee Cheung <[email protected]> Date: Wed Oct 15 13:32:53 2025 +0200 1 file changed, 2 insertions(+), 2 deletions(-) Auto-merging doc/api/vm.md [main 5f1d913e22] fixup! vm: make vm.Module.evaluate() conditionally synchronous Author: Joyee Cheung <[email protected]> Date: Thu Oct 16 17:50:03 2025 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- benchmark: add benchmark for leaf source text modules

PR-URL: #60205
Refs: #59656
Refs: #37648
Reviewed-By: Chengzhong Wu <[email protected]>

[detached HEAD 91bb4b6f50] benchmark: add benchmark for leaf source text modules
Author: Joyee Cheung <[email protected]>
Date: Sun Oct 12 19:47:58 2025 +0200
1 file changed, 84 insertions(+)
create mode 100644 benchmark/vm/source-text-module-leaf.js
Rebasing (3/6)
Rebasing (4/6)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
vm: make vm.Module.evaluate() conditionally synchronous

Make sure that the vm.Module.evaluate() method is conditionally
synchronous based on the specification. Previously, the returned
promise is unconditionally pending (even for synthetic modules and
source text modules without top-level await) instead of immediately
fulfilled, making it harder to debug as it deviates from the
specified behavior.
Clarify the synchronicity of this method in the documentation
Add more tests for the synchronicity of this method.

PR-URL: #60205
Refs: #59656
Refs: #37648
Reviewed-By: Chengzhong Wu <[email protected]>

[detached HEAD 3967194773] vm: make vm.Module.evaluate() conditionally synchronous
Author: Joyee Cheung <[email protected]>
Date: Fri Oct 10 20:20:09 2025 +0200
6 files changed, 390 insertions(+), 30 deletions(-)
create mode 100644 test/parallel/test-vm-module-evaluate-source-text-module.js
create mode 100644 test/parallel/test-vm-module-evaluate-synthethic-module-rejection.js
create mode 100644 test/parallel/test-vm-module-evaluate-synthethic-module.js
create mode 100644 test/parallel/test-vm-module-evaluate-while-evaluating.js
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/18612987296

nodejs-github-bot · 2025-10-18T08:20:49Z

Landed in d695004...38bf955

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

- Make sure that the vm.Module.evaluate() method is conditionally synchronous based on the specification. Previously, the returned promise is unconditionally pending (even for synthetic modules and source text modules without top-level await) instead of immediately fulfilled, making it harder to debug as it deviates from the specified behavior. - Clarify the synchronicity of this method in the documentation - Add more tests for the synchronicity of this method. PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

- Make sure that the vm.Module.evaluate() method is conditionally synchronous based on the specification. Previously, the returned promise is unconditionally pending (even for synthetic modules and source text modules without top-level await) instead of immediately fulfilled, making it harder to debug as it deviates from the specified behavior. - Clarify the synchronicity of this method in the documentation - Add more tests for the synchronicity of this method. PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

- Make sure that the vm.Module.evaluate() method is conditionally synchronous based on the specification. Previously, the returned promise is unconditionally pending (even for synthetic modules and source text modules without top-level await) instead of immediately fulfilled, making it harder to debug as it deviates from the specified behavior. - Clarify the synchronicity of this method in the documentation - Add more tests for the synchronicity of this method. PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

- Make sure that the vm.Module.evaluate() method is conditionally synchronous based on the specification. Previously, the returned promise is unconditionally pending (even for synthetic modules and source text modules without top-level await) instead of immediately fulfilled, making it harder to debug as it deviates from the specified behavior. - Clarify the synchronicity of this method in the documentation - Add more tests for the synchronicity of this method. PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `25.0.0` -> `25.1.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v25.1.0`](https://github.com/nodejs/node/releases/tag/v25.1.0): 2025-10-28, Version 25.1.0 (Current), @aduh95 [Compare Source](nodejs/node@v25.0.0...v25.1.0) ##### Notable Changes - \[[`4395fe14b9`](nodejs/node@4395fe14b9)] - **(SEMVER-MINOR)** **http**: add optimizeEmptyRequests server option (Rafael Gonzaga) [#59778](nodejs/node#59778) - \[[`2e55c6ad04`](nodejs/node@2e55c6ad04)] - **(SEMVER-MINOR)** **sqlite**: allow setting defensive flag (Bart Louwers) [#60217](nodejs/node#60217) - \[[`f437204491`](nodejs/node@f437204491)] - **(SEMVER-MINOR)** **src**: add watch config namespace (Marco Ippolito) [#60178](nodejs/node#60178) ##### Commits - \[[`bb27766bd5`](nodejs/node@bb27766bd5)] - **benchmark**: improve cpu.sh for safety and usability (Nam Yooseong) [#60162](nodejs/node#60162) - \[[`e600711c20`](nodejs/node@e600711c20)] - **benchmark**: add benchmark for leaf source text modules (Joyee Cheung) [#60205](nodejs/node#60205) - \[[`1bbcdf9039`](nodejs/node@1bbcdf9039)] - **benchmark**: add vm.SourceTextModule benchmark (Joyee Cheung) [#59396](nodejs/node#59396) - \[[`22fa6bd28b`](nodejs/node@22fa6bd28b)] - **build**: ibmi follow aix visibility (SRAVANI GUNDEPALLI) [#60360](nodejs/node#60360) - \[[`931028400e`](nodejs/node@931028400e)] - **build**: use call command when calling python configure (Jacob Nichols) [#60098](nodejs/node#60098) - \[[`17fde3f3d1`](nodejs/node@17fde3f3d1)] - **build**: build v8 with -fvisibility=hidden -fvisibility-inlines-hidden (Joyee Cheung) [#56290](nodejs/node#56290) - \[[`04cc7aae5e`](nodejs/node@04cc7aae5e)] - **build**: remove V8\_COMPRESS\_POINTERS\_IN\_ISOLATE\_CAGE defs (Joyee Cheung) [#60296](nodejs/node#60296) - \[[`8a2053060d`](nodejs/node@8a2053060d)] - **crypto**: update root certificates to NSS 3.116 (Node.js GitHub Bot) [#59956](nodejs/node#59956) - \[[`fe91c0f755`](nodejs/node@fe91c0f755)] - **deps**: update simdjson to 4.0.7 (Node.js GitHub Bot) [#59883](nodejs/node#59883) - \[[`aacfc0d212`](nodejs/node@aacfc0d212)] - **deps**: update corepack to 0.34.1 (Node.js GitHub Bot) [#60314](nodejs/node#60314) - \[[`8596891a71`](nodejs/node@8596891a71)] - **deps**: update inspector\_protocol to [`af7f5a8`](nodejs/node@af7f5a8) (Node.js GitHub Bot) [#60312](nodejs/node#60312) - \[[`21bcd0eb2f`](nodejs/node@21bcd0eb2f)] - **deps**: V8: cherry-pick [`3d0f462`](nodejs/node@3d0f462a17ff) (Joyee Cheung) [#59396](nodejs/node#59396) - \[[`673558501c`](nodejs/node@673558501c)] - **deps**: update googletest to [`279f847`](nodejs/node@279f847) (Node.js GitHub Bot) [#60219](nodejs/node#60219) - \[[`425a1879b1`](nodejs/node@425a1879b1)] - **doc**: mention more codemods in `deprecations.md` (Augustin Mauroy) [#60243](nodejs/node#60243) - \[[`563e1317f3`](nodejs/node@563e1317f3)] - **doc**: remove unnecessary statement of web storage (Deokjin Kim) [#60363](nodejs/node#60363) - \[[`064c8c5cfd`](nodejs/node@064c8c5cfd)] - **doc**: add missing CAA type to dns.resolveAny() & dnsPromises.resolveAny() (Jimmy Leung) [#58899](nodejs/node#58899) - \[[`99e357af35`](nodejs/node@99e357af35)] - **doc**: use `any` for `worker_threads.Worker` 'error' event argument `err` (Jonas Geiler) [#60300](nodejs/node#60300) - \[[`8ccff0d934`](nodejs/node@8ccff0d934)] - **doc**: update decorator documentation to reflect actual policy (Muhammad Salman Aziz) [#60288](nodejs/node#60288) - \[[`bac70c6ef3`](nodejs/node@bac70c6ef3)] - **doc**: document wildcard supported by tools/test.py (Joyee Cheung) [#60265](nodejs/node#60265) - \[[`8492bc6a88`](nodejs/node@8492bc6a88)] - **doc**: add --heap-snapshot-on-oom to useful v8 flag (jakecastelli) [#60260](nodejs/node#60260) - \[[`0f0d3c0e47`](nodejs/node@0f0d3c0e47)] - **doc**: fix `blob.bytes()` heading level (XTY) [#60252](nodejs/node#60252) - \[[`8c8525cf93`](nodejs/node@8c8525cf93)] - **doc**: fix not working code example in vm docs (Artur Gawlik) [#60224](nodejs/node#60224) - \[[`8a6de3866c`](nodejs/node@8a6de3866c)] - **doc, assert**: correct order of changes entries (Gerhard Stöbich) [#60304](nodejs/node#60304) - \[[`6bacb6555a`](nodejs/node@6bacb6555a)] - **doc, module**: change async customization hooks to experimental (Gerhard Stöbich) [#60302](nodejs/node#60302) - \[[`6f3b16df16`](nodejs/node@6f3b16df16)] - **esm**: use index-based resolution callbacks (Joyee Cheung) [#59396](nodejs/node#59396) - \[[`95644a432c`](nodejs/node@95644a432c)] - **http**: lazy allocate cookies array (Robert Nagy) [#59734](nodejs/node#59734) - \[[`4395fe14b9`](nodejs/node@4395fe14b9)] - **(SEMVER-MINOR)** **http**: add optimizeEmptyRequests server option (Rafael Gonzaga) [#59778](nodejs/node#59778) - \[[`f1aa1eaaf5`](nodejs/node@f1aa1eaaf5)] - **inspector**: add network payload buffer size limits (Chengzhong Wu) [#60236](nodejs/node#60236) - \[[`64fc625bf9`](nodejs/node@64fc625bf9)] - **inspector**: support handshake response for websocket inspection (Shima Ryuhei) [#60225](nodejs/node#60225) - \[[`0ecbb806a8`](nodejs/node@0ecbb806a8)] - **lib**: fix typo in createBlobReaderStream (SeokHun) [#60132](nodejs/node#60132) - \[[`ffec5927fd`](nodejs/node@ffec5927fd)] - **meta**: fix typo in test-shared workflow name (Ronit Sabhaya) [#60321](nodejs/node#60321) - \[[`a02897e157`](nodejs/node@a02897e157)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#60325](nodejs/node#60325) - \[[`59223a7831`](nodejs/node@59223a7831)] - **meta**: loop userland-migrations in deprecations (Chengzhong Wu) [#60299](nodejs/node#60299) - \[[`2d48d17696`](nodejs/node@2d48d17696)] - **module**: refactor and clarify async loader hook customizations (Joyee Cheung) [#60278](nodejs/node#60278) - \[[`be1b84fd93`](nodejs/node@be1b84fd93)] - **module**: handle null source from async loader hooks in sync hooks (Joyee Cheung) [#59929](nodejs/node#59929) - \[[`063fbd87d3`](nodejs/node@063fbd87d3)] - **msi**: fix WiX warnings (Stefan Stojanovic) [#60251](nodejs/node#60251) - \[[`2e55c6ad04`](nodejs/node@2e55c6ad04)] - **(SEMVER-MINOR)** **sqlite**: allow setting defensive flag (Bart Louwers) [#60217](nodejs/node#60217) - \[[`dc93d6988a`](nodejs/node@dc93d6988a)] - **src**: fix timing of snapshot serialize callback (Joyee Cheung) [#60434](nodejs/node#60434) - \[[`267e1b3817`](nodejs/node@267e1b3817)] - **src**: add COUNT\_GENERIC\_USAGE utility for tests (Joyee Cheung) [#60434](nodejs/node#60434) - \[[`4a5d7a4c2a`](nodejs/node@4a5d7a4c2a)] - **src**: conditionally disable source phase imports by default (Shelley Vohr) [#60364](nodejs/node#60364) - \[[`f437204491`](nodejs/node@f437204491)] - **(SEMVER-MINOR)** **src**: add watch config namespace (Marco Ippolito) [#60178](nodejs/node#60178) - \[[`36837fa0f9`](nodejs/node@36837fa0f9)] - **src**: use cached primordials\_string (Sohyeon Kim) [#60255](nodejs/node#60255) - \[[`df8396ad37`](nodejs/node@df8396ad37)] - **src**: replace Environment::GetCurrent with args.GetIsolate (Sohyeon Kim) [#60256](nodejs/node#60256) - \[[`5dd670b2b9`](nodejs/node@5dd670b2b9)] - **src**: initial enablement of IsolateGroups (James M Snell) [#60254](nodejs/node#60254) - \[[`afdb362933`](nodejs/node@afdb362933)] - **src**: use `Utf8Value` and `TwoByteValue` instead of V8 helpers (Anna Henningsen) [#60244](nodejs/node#60244) - \[[`a40e533e72`](nodejs/node@a40e533e72)] - **src**: add a default branch for module phase (Chengzhong Wu) [#60261](nodejs/node#60261) - \[[`42729f07ee`](nodejs/node@42729f07ee)] - **src**: stop using deprecated v8::Context::GetIsolate (Michaël Zasso) [#60223](nodejs/node#60223) - \[[`7a6542c205`](nodejs/node@7a6542c205)] - **test**: skip failing test on macOS 15.7+ (Antoine du Hamel) [#60419](nodejs/node#60419) - \[[`29a5855a4f`](nodejs/node@29a5855a4f)] - **test**: ensure assertions are reachable in `test/addons` (Antoine du Hamel) [#60142](nodejs/node#60142) - \[[`12773d19c4`](nodejs/node@12773d19c4)] - **test**: increase debugger waitFor timeout on macOS (Chengzhong Wu) [#60367](nodejs/node#60367) - \[[`0b38de3e9e`](nodejs/node@0b38de3e9e)] - **test**: put helper in test-runner-output into common (Joyee Cheung) [#60330](nodejs/node#60330) - \[[`6de2407c44`](nodejs/node@6de2407c44)] - **test**: fix small compile warning in test\_network\_requests\_buffer.cc (xiaocainiao633) [#60281](nodejs/node#60281) - \[[`4b23ac8613`](nodejs/node@4b23ac8613)] - **test**: fix status when compiled without inspector (Antoine du Hamel) [#60289](nodejs/node#60289) - \[[`a07f32e326`](nodejs/node@a07f32e326)] - **test**: split test-runner-watch-mode-kill-signal (Joyee Cheung) [#60298](nodejs/node#60298) - \[[`30451d32d7`](nodejs/node@30451d32d7)] - **test**: fix incorrect calculation in test-perf-hooks.js (Joyee Cheung) [#60271](nodejs/node#60271) - \[[`e3c3b48f1c`](nodejs/node@e3c3b48f1c)] - **test**: ignore EPIPE errors in https proxy invalid URL test (Joyee Cheung) [#60269](nodejs/node#60269) - \[[`405a9c4c5f`](nodejs/node@405a9c4c5f)] - **test**: parallelize test-without-async-context-frame correctly (Joyee Cheung) [#60273](nodejs/node#60273) - \[[`ffeebebc71`](nodejs/node@ffeebebc71)] - **test**: make test-worker-prof more tolerant (Joyee Cheung) [#60272](nodejs/node#60272) - \[[`26b01bf170`](nodejs/node@26b01bf170)] - **test**: skip sea tests on x64 macOS (Joyee Cheung) [#60250](nodejs/node#60250) - \[[`8caae1a05b`](nodejs/node@8caae1a05b)] - **test**: move sea tests into test/sea (Joyee Cheung) [#60250](nodejs/node#60250) - \[[`3d183e3e9f`](nodejs/node@3d183e3e9f)] - **test,crypto**: fix conditional SHA3-\* skip on BoringSSL (Filip Skokan) [#60379](nodejs/node#60379) - \[[`e83dbcba94`](nodejs/node@e83dbcba94)] - **test,crypto**: sha3 algorithms aren't supported with BoringSSL (Shelley Vohr) [#60374](nodejs/node#60374) - \[[`3d89331496`](nodejs/node@3d89331496)] - **test\_runner**: use module.registerHooks in module mocks (Joyee Cheung) [#60326](nodejs/node#60326) - \[[`377e8ce85a`](nodejs/node@377e8ce85a)] - **tls**: avoid external memory leak on invalid protocol versions (Shelley Vohr) [#60390](nodejs/node#60390) - \[[`ae4858c1f6`](nodejs/node@ae4858c1f6)] - **tools**: add an option to generate lighter archives (Antoine du Hamel) [#60294](nodejs/node#60294) - \[[`cb615b1a2e`](nodejs/node@cb615b1a2e)] - **tools**: skip test-shared workflow for draft MRs (Michaël Zasso) [#60365](nodejs/node#60365) - \[[`03b034731e`](nodejs/node@03b034731e)] - **tools**: disable inspector on macOS-shared to reduce flakiness (Antoine du Hamel) [#60320](nodejs/node#60320) - \[[`f402b4e1d1`](nodejs/node@f402b4e1d1)] - **tools**: show diff alongside the error in Nix linter (Antoine du Hamel) [#60301](nodejs/node#60301) - \[[`5d5c8483fb`](nodejs/node@5d5c8483fb)] - **tools**: run CI with shared libs on GHA (Antoine du Hamel) [#60121](nodejs/node#60121) - \[[`e8fdd8d2e8`](nodejs/node@e8fdd8d2e8)] - **tools**: update gyp-next to 0.20.5 (Node.js GitHub Bot) [#60313](nodejs/node#60313) - \[[`6e8b029a21`](nodejs/node@6e8b029a21)] - **tools**: limit inspector protocol MR title length (Chengzhong Wu) [#60324](nodejs/node#60324) - \[[`a5073086c6`](nodejs/node@a5073086c6)] - **tools**: fix inspector\_protocol updater (Chengzhong Wu) [#60277](nodejs/node#60277) - \[[`47fa765bff`](nodejs/node@47fa765bff)] - **tools**: optimize wildcard execution in tools/test.py (Joyee Cheung) [#60266](nodejs/node#60266) - \[[`11ebb0447d`](nodejs/node@11ebb0447d)] - **tools**: add C++ lint rule to avoid using `String::Utf8Value` (Anna Henningsen) [#60244](nodejs/node#60244) - \[[`14f3189670`](nodejs/node@14f3189670)] - **tools**: add inspector\_protocol updater (Chengzhong Wu) [#60245](nodejs/node#60245) - \[[`ef4c596fc6`](nodejs/node@ef4c596fc6)] - **typings**: add missing properties and method in Worker (Woohyun Sung) [#60257](nodejs/node#60257) - \[[`09ae6fc065`](nodejs/node@09ae6fc065)] - **typings**: add missing properties in HTTPParser (Woohyun Sung) [#60257](nodejs/node#60257) - \[[`9ecaf41f8e`](nodejs/node@9ecaf41f8e)] - **typings**: delete undefined property in ConfigBinding (Woohyun Sung) [#60257](nodejs/node#60257) - \[[`4a86016e86`](nodejs/node@4a86016e86)] - **util**: use more defensive code when inspecting error objects (Antoine du Hamel) [#60139](nodejs/node#60139) - \[[`9e6d6cec59`](nodejs/node@9e6d6cec59)] - **util**: mark special properties when inspecting them (Ruben Bridgewater) [#60131](nodejs/node#60131) - \[[`79b2387fd9`](nodejs/node@79b2387fd9)] - **vm**: make vm.Module.evaluate() conditionally synchronous (Joyee Cheung) [#60205](nodejs/node#60205) - \[[`e5559f3be3`](nodejs/node@e5559f3be3)] - **win**: upgrade Visual Studio workload from 2019 to 2022 (Jiawen Geng) [#60318](nodejs/node#60318) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

nodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Oct 10, 2025

legendecas reviewed Oct 12, 2025

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

test/parallel/test-vm-module-evaluate-source-text-module.js Show resolved Hide resolved

lib/internal/vm/module.js Show resolved Hide resolved

legendecas reviewed Oct 12, 2025

View reviewed changes

test/parallel/test-vm-module-evaluate-source-text-module.js Show resolved Hide resolved

benchmark: add benchmark for leaf source text modules

5237650

joyeecheung force-pushed the vm-evaluate branch from 63566f6 to a482e51 Compare October 12, 2025 17:51

joyeecheung force-pushed the vm-evaluate branch from a482e51 to d308c89 Compare October 13, 2025 10:30

joyeecheung mentioned this pull request Oct 13, 2025

vm.Module.evaluate() morphs loader errors into module evaluation rejections #60242

Open

legendecas approved these changes Oct 14, 2025

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

doc/api/vm.md Outdated Show resolved Hide resolved

joyeecheung added a commit to joyeecheung/node that referenced this pull request Oct 15, 2025

fixup! vm: make vm.Module.evaluate() conditionally synchronous nodejs…

8a5993e

…#60205 Co-authored-by: Chengzhong Wu <[email protected]>

fixup! vm: make vm.Module.evaluate() conditionally synchronous

52ebb46

Co-authored-by: Chengzhong Wu <[email protected]>

joyeecheung force-pushed the vm-evaluate branch from 8a5993e to 52ebb46 Compare October 15, 2025 11:35

legendecas reviewed Oct 16, 2025

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

joyeecheung commented Oct 16, 2025

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

fixup! vm: make vm.Module.evaluate() conditionally synchronous

6cdd4dc

legendecas approved these changes Oct 17, 2025

View reviewed changes

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 18, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2025

nodejs-github-bot pushed a commit that referenced this pull request Oct 18, 2025

benchmark: add benchmark for leaf source text modules

8b52c89

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

nodejs-github-bot closed this Oct 18, 2025

aduh95 pushed a commit that referenced this pull request Oct 23, 2025

benchmark: add benchmark for leaf source text modules

e600711

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

github-actions bot mentioned this pull request Oct 27, 2025

2025-10-28, Version 25.1.0 (Current) #60436

Merged

aduh95 pushed a commit that referenced this pull request Oct 31, 2025

benchmark: add benchmark for leaf source text modules

3b00370

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 pushed a commit that referenced this pull request Oct 31, 2025

benchmark: add benchmark for leaf source text modules

5e374e9

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

Uh oh!

vm: make vm.Module.evaluate() conditionally synchronous #60205

vm: make vm.Module.evaluate() conditionally synchronous #60205

Uh oh!

Conversation

joyeecheung commented Oct 10, 2025

Uh oh!

codecov bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joyeecheung commented Oct 12, 2025

Uh oh!

joyeecheung commented Oct 13, 2025

Uh oh!

joyeecheung commented Oct 13, 2025

Uh oh!

nodejs-github-bot commented Oct 13, 2025

Uh oh!

nodejs-github-bot commented Oct 14, 2025

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 15, 2025

Uh oh!

nodejs-github-bot commented Oct 15, 2025

Uh oh!

joyeecheung commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 16, 2025

Uh oh!

nodejs-github-bot commented Oct 17, 2025

Uh oh!

nodejs-github-bot commented Oct 17, 2025

Uh oh!

nodejs-github-bot commented Oct 17, 2025

Uh oh!

nodejs-github-bot commented Oct 17, 2025

Uh oh!

nodejs-github-bot commented Oct 18, 2025

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #60205 Refs: #59656 Refs: #37648 Reviewed-By: Chengzhong Wu <[email protected]>

Uh oh!

nodejs-github-bot commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 10, 2025 •

edited

Loading

PR-URL: #60205
Refs: #59656
Refs: #37648
Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #60205
Refs: #59656
Refs: #37648
Reviewed-By: Chengzhong Wu <[email protected]>