Skip to content

Conversation

@abdulfarid-dev
Copy link

Summary

Replaced the old Node.js logo with the updated version to maintain consistency with the current branding.

Changes

  • Updated logo file in doc/images/logo.png
  • Updated documentation to point to the new logo

Reason

The previous logo was outdated. This update aligns with the latest Node.js brand assets.

Signed-off-by: Abdul Farid [email protected]

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 11, 2025
@marco-ippolito
Copy link
Member

What is the new logo? Can you provide some context?

@abdulfarid-dev
Copy link
Author

abdulfarid-dev commented Oct 12, 2025 via email

Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change does not look correct, and there is no rationale for changing these images with completely different one

@abdulfarid-dev
Copy link
Author

abdulfarid-dev commented Oct 12, 2025 via email

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a PNG image with .jpg file extension is a bad idea, it's going to be confusing for both humans and machines

@abdulfarid-dev
Copy link
Author

Hi @marco-ippolito, Thank you for your feedback! I’m still learning the contribution process and want to make sure I follow the guidelines correctly. Could you please clarify what would be the correct way to update the logos/images? I want to make the change correctly without replacing them incorrectly. Thanks for your guidance!

On Sun, 12 Oct 2025, 11:55 Marco Ippolito, @.> wrote: @.* requested changes on this pull request. this change does not look correct, and there is no rationale for changing these images with completely different one — Reply to this email directly, view it on GitHub <#60218 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BONRN5QOIDAJCQG2AMIJIUT3XHX7FAVCNFSM6AAAAACI54KK42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMRXHEYTKNJZGA . You are receiving this because you authored the thread.Message ID: @.***>

cc: @marco-ippolito , can you PTAL

@marco-ippolito
Copy link
Member

marco-ippolito commented Oct 29, 2025

What problem are you trying to solve with this PR, you still did not provide a rationale, nor addressed comments left by other collaborators

@abdulfarid-dev
Copy link
Author

Ref #60213

@richardlau
Copy link
Member

These do not look right. As far as I can tell, these images are used in the Windows and macOS installers and given the differences between the old and new versions this PR will probably result in visual artifacts (either truncation/stretching).

For macOS you should be able to build the macOS installer with

make pkg

and the Windows installer with

vcbuild msi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants