Skip to content

src: use Utf8Value and TwoByteValue instead of V8 helpers #60244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

src: use Utf8Value and TwoByteValue instead of V8 helpers #60244

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f25b66
src: use `Utf8Value` and `TwoByteValue` instead of V8 helpers
addaleax Oct 13, 2025
83907b6
tools: add C++ lint rule to avoid using `String::Utf8Value`
addaleax Oct 13, 2025
9226bb1
fixup! src: use `Utf8Value` and `TwoByteValue` instead of V8 helpers
addaleax Oct 13, 2025
2f9d49a
fixup! tools: add C++ lint rule to avoid using `String::Utf8Value`
addaleax Oct 13, 2025
c05de02
fixup! src: use `Utf8Value` and `TwoByteValue` instead of V8 helpers
addaleax Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: use Utf8Value and TwoByteValue instead of V8 helpers
  • Loading branch information
@addaleax
addaleax committed Oct 14, 2025
commit c05de02ea134b3b0543e027269cdbbd3f40a551f
8 changes: 5 additions & 3 deletions src/api/hooks.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ using v8::Isolate;
using v8::Just;
using v8::Local;
using v8::Maybe;
using v8::NewStringType;
using v8::Nothing;
using v8::Object;
using v8::String;
Expand Down Expand Up @@ -209,9 +210,10 @@ async_context EmitAsyncInit(Isolate* isolate,
std::string_view name,
async_id trigger_async_id) {
HandleScope handle_scope(isolate);
Local<String> type = ToV8Value(isolate->GetCurrentContext(), name, isolate)
.ToLocalChecked()
.As<String>();
Local<String> type =
String::NewFromUtf8(
isolate, name.data(), NewStringType::kInternalized, name.size())
.ToLocalChecked();
return EmitAsyncInit(isolate, resource, type, trigger_async_id);
}

Expand Down
Loading