Skip to content

test: make test-worker-prof more tolerant #60272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

test: make test-worker-prof more tolerant #60272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: make test-worker-prof more tolerant 
It seems after the recent V8 upgrade, it's no longer safe to assume
there'll be 15 ticks per 1500ms. Lower it to 10 ticks.
  • Loading branch information
@joyeecheung
joyeecheung committed Oct 15, 2025
commit e223c3d709739d3a64d5a8c0456483ca0296e967
6 changes: 3 additions & 3 deletions test/sequential/test-worker-prof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ if (process.argv[2] === 'child') {
// When not tracking Worker threads, only 1 or 2 ticks would
// have been recorded.
// prof_sampling_interval is by default 1 millisecond. A higher SPIN_MS
// should result in more ticks, while 15 should be safe on most machines.
assert(workerTicks.length > 15, `worker ticks <= 15:\n${workerTicks.join('\n')}`);
assert(parentTicks.length > 15, `parent ticks <= 15:\n${parentTicks.join('\n')}`);
// should result in more ticks, while 10 should be safe on most machines.
assert(workerTicks.length > 10, `worker ticks <= 10:\n${workerTicks.join('\n')}`);
assert(parentTicks.length > 10, `parent ticks <= 10:\n${parentTicks.join('\n')}`);
}
Loading