Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 17, 2025

  • it allows non-collaborators can run them on their forks.
  • testing on different arch gives more relevant results.
  • if folks want to run benchmarks on their own machine, I find it helpful to have a GHA workflow to copy to understand how to set it up.

Example of benchmark workflow: https://github.com/aduh95/node/actions/runs/18478104954

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 17, 2025
@targos
Copy link
Member

targos commented Oct 17, 2025

I would not be very confident running benchmarks on Cloud VMs that we don't know much about. That's why we have dedicated bare metal machines for that in CI.

@aduh95
Copy link
Contributor Author

aduh95 commented Oct 17, 2025

I would not be very confident running benchmarks on Cloud VMs that we don't know much about. That's why we have dedicated bare metal machines for that in CI.

Do you think we should add a comment about that in the output? This probably goes without saying, but I'm not suggesting we get rid of the bare metal machines, I'm suggesting that as an addition.

@targos
Copy link
Member

targos commented Oct 17, 2025

Maybe. Something that says only the results of the Jenkins benchmark CI can be used make a decision.

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 26, 2025
@aduh95
Copy link
Contributor Author

aduh95 commented Dec 15, 2025

One upside of having something like that: it allows one to validate changes to the Benchmark tooling during a CI lockdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants