tools: only add test reporter args when node:test is used #60551
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the test does not use node:test, don't append the unnecessary arguments to avoid cluttering the command line printed by the test runner when the test fails.
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60551 +/- ##
==========================================
+ Coverage 88.05% 88.55% +0.50%
==========================================
Files 704 704
Lines 207857 207863 +6
Branches 39964 40048 +84
==========================================
+ Hits 183030 184079 +1049
+ Misses 16806 15827 -979
+ Partials 8021 7957 -64 🚀 New features to boost your workflow:
|
aduh95
approved these changes
Nov 2, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
lpinca
approved these changes
Nov 3, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in be60e4e |
aduh95
pushed a commit
that referenced
this pull request
Nov 5, 2025
If the test does not use node:test, don't append the unnecessary arguments to avoid cluttering the command line printed by the test runner when the test fails. PR-URL: #60551 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test does not use node:test, don't append the unnecessary arguments to avoid cluttering the command line printed by the test runner when the test fails.