Skip to content

Conversation

@juanarbol
Copy link
Member

@juanarbol juanarbol commented Nov 5, 2025

PR-URL: #58124
Backport-PR-URL: #60579
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Santiago Gimeno [email protected]
Reviewed-By: Juan José Arboleda [email protected]
Reviewed-By: Antoine du Hamel [email protected]


Let's give it a try...

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2025

Review requested:

  • @nodejs/releasers

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Nov 5, 2025
juanarbol pushed a commit to juanarbol/node that referenced this pull request Nov 5, 2025
PR-URL: nodejs#58124
Backport-PR-URL: nodejs#60579
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Signed-off-by: Juan José Arboleda <[email protected]>
@juanarbol juanarbol force-pushed the juan/backport-uv-1.51.0 branch from 638e6fc to bce9d7e Compare November 5, 2025 00:39
@juanarbol juanarbol changed the title deps: update libuv to 1.51.0 [backport-v20.x] deps: update libuv to 1.51.0 Nov 5, 2025
@nodejs-github-bot
Copy link
Collaborator

@juanarbol
Copy link
Member Author

juanarbol commented Nov 5, 2025

I think I need to re-apply 42e659c or resolve the merge conflict better. Also libuv/libuv#4416 (comment) seems a good option.

PR-URL: nodejs#58124
Backport-PR-URL: nodejs#60579
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Signed-off-by: Juan José Arboleda <[email protected]>
@juanarbol juanarbol force-pushed the juan/backport-uv-1.51.0 branch from bce9d7e to 4a50b37 Compare November 5, 2025 20:00
@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito
Copy link
Member

@juanarbol can you rebase and re run CI so we can land this?

@richardlau
Copy link
Member

Given all the issues that occurred with io_uring support, I'm a little hesitant to update libuv in Node.js 20 from 1.46.0.

@marco-ippolito marco-ippolito force-pushed the v20.x-staging branch 2 times, most recently from c017391 to 144233b Compare November 19, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants