-
-
Notifications
You must be signed in to change notification settings - Fork 34k
[backport-v20.x] deps: update libuv to 1.51.0 #60579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juanarbol
wants to merge
1
commit into
nodejs:v20.x-staging
Choose a base branch
from
juanarbol:juan/backport-uv-1.51.0
base: v20.x-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Nov 5, 2025
PR-URL: nodejs#58124 Backport-PR-URL: nodejs#60579 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Signed-off-by: Juan José Arboleda <[email protected]>
638e6fc to
bce9d7e
Compare
Collaborator
Member
Author
|
I think I need to re-apply 42e659c or resolve the merge conflict better. Also libuv/libuv#4416 (comment) seems a good option. |
PR-URL: nodejs#58124 Backport-PR-URL: nodejs#60579 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Signed-off-by: Juan José Arboleda <[email protected]>
bce9d7e to
4a50b37
Compare
Collaborator
Member
|
@juanarbol can you rebase and re run CI so we can land this? |
Member
|
Given all the issues that occurred with |
c017391 to
144233b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #58124
Backport-PR-URL: #60579
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Santiago Gimeno [email protected]
Reviewed-By: Juan José Arboleda [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Let's give it a try...