Skip to content

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Nov 10, 2025

Fixes: #60656

The test was setting keepAliveTimeout with platformTimeout() but
keepAliveTimeoutBuffer remained at the hardcoded default of 1000ms.
This caused timing issues on slow CI platforms where platformTimeout
scales up timeout values but the buffer did not scale accordingly.

Now both keepAliveTimeout and keepAliveTimeoutBuffer are set using
platformTimeout() to ensure consistent behavior across all platforms

image

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 10, 2025
@Han5991 Han5991 marked this pull request as ready for review November 10, 2025 13:07
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (bd3a202) to head (ce00f6a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60664      +/-   ##
==========================================
- Coverage   88.55%   88.53%   -0.02%     
==========================================
  Files         703      703              
  Lines      208077   208077              
  Branches    40083    40081       -2     
==========================================
- Hits       184254   184221      -33     
- Misses      15841    15876      +35     
+ Partials     7982     7980       -2     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: keepAliveTimeoutBuffer should be common.platformTimeout(1000)

2 participants