Skip to content

src,permission: fix permission.has on empty param #60674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Nov 16, 2025
Merged

src,permission: fix permission.has on empty param #60674

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1535bdc
src,permission: fix permission.has on empty param
RafaelGSS Nov 10, 2025
531788c
fixup! src,permission: fix permission.has on empty param
RafaelGSS Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src,permission: fix permission.has on empty param
  • Loading branch information
@RafaelGSS
RafaelGSS committed Nov 11, 2025
commit 531788cde0d4be5d79a6d2984143a0b86b9ff96c
6 changes: 2 additions & 4 deletions src/permission/fs_permission.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,13 @@ bool FSPermission::is_granted(Environment* env,
return allow_all_in_;
}
return !deny_all_in_ &&
(allow_all_in_ ||
is_tree_granted(env, &granted_in_fs_, param));
(allow_all_in_ || is_tree_granted(env, &granted_in_fs_, param));
case PermissionScope::kFileSystemWrite:
if (param.empty()) {
return allow_all_out_;
}
return !deny_all_out_ &&
(allow_all_out_ ||
is_tree_granted(env, &granted_out_fs_, param));
(allow_all_out_ || is_tree_granted(env, &granted_out_fs_, param));
default:
return false;
}
Expand Down
Loading