Skip to content

src: optimize trace_name allocation in Worker::Run #60886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertcanaltin wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −2
Open

src: optimize trace_name allocation in Worker::Run #60886

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c80bc1
src: optimize trace_name allocation in Worker::Run
mertcanaltin Nov 28, 2025
8ea8692
src: optimize trace_name allocation in Worker::Run
mertcanaltin Nov 29, 2025
1b54dd6
src: optimize trace_name allocation in Worker::Run
mertcanaltin Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/node_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,18 @@ size_t Worker::NearHeapLimit(void* data, size_t current_heap_limit,
}

void Worker::Run() {
std::string trace_name = "[worker " + std::to_string(thread_id_.id) + "]" +
(name_ == "" ? "" : " " + name_);
std::string trace_name;
std::string id = std::to_string(thread_id_.id);
// Pre-allocate space: "[worker " (8) + thread_id + "]" (1)
// + (if name exists: " " (1) + name)
trace_name.reserve(9 + id.size() + name_.size());
trace_name = "[worker ";
trace_name += id;
trace_name += "]";
if (!name_.empty()) {
trace_name += " ";
trace_name += name_;
}
TRACE_EVENT_METADATA1(
"__metadata", "thread_name", "name", TRACE_STR_COPY(trace_name.c_str()));
CHECK_NOT_NULL(platform_);
Expand Down
Loading