Skip to content

src: dump snapshot source with node:generate_default_snapshot_source #61101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jan 3, 2026
+21 −29
Merged

src: dump snapshot source with node:generate_default_snapshot_source #61101

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc1ac1e
src: dump snapshot source with node:generate_default_snapshot_source
joyeecheung Dec 17, 2025
b6ace85
fixup! src: dump snapshot source with node:generate_default_snapshot_…
joyeecheung Dec 19, 2025
09ccbcf
fixup! fixup! src: dump snapshot source with node:generate_default_sn…
joyeecheung Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! src: dump snapshot source with node:generate_default_sn… 
…apshot_source
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 19, 2025
commit 09ccbcf0b06606491d1405edc8f4a0abcbb5d68a
11 changes: 6 additions & 5 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,11 +1380,12 @@ ExitCode GenerateAndWriteSnapshotData(const SnapshotData** snapshot_data_ptr,
if (builder_script == "node:generate_default_snapshot_source") {
// Reset to empty to generate from scratch.
snapshot_config.builder_script_path = {};
exit_code = node::SnapshotBuilder::GenerateAsSource("snapshot.cc",
args_maybe_patched,
result->exec_args(),
snapshot_config,
true /* use_array_literals */);
exit_code =
node::SnapshotBuilder::GenerateAsSource("snapshot.cc",
args_maybe_patched,
result->exec_args(),
snapshot_config,
true /* use_array_literals */);
return exit_code;
}

Expand Down
Loading