Skip to content

fix: custom inspect should not throw when called with wrong this #61128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Dec 22, 2025
Merged

fix: custom inspect should not throw when called with wrong this #61128

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3edbd1
events: remove eventtarget custom inspect branding
efekrskl Dec 19, 2025
830ace5
test: test eventtarget custom inspect w/o branding
efekrskl Dec 19, 2025
bf43b8a
test: use check output type instead of using doesNotThrow
efekrskl Dec 21, 2025
d8e55f9
test: fix lint errors
efekrskl Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix lint errors
  • Loading branch information
@efekrskl
efekrskl committed Dec 21, 2025
commit d8e55f9efea47e5d6344b11a4248e9aefa880ba1
4 changes: 2 additions & 2 deletions test/parallel/test-eventtarget-custom-inspect-does-not-throw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';

require('../common');
const assert = require('assert');
const util = require('util');

Expand All @@ -12,8 +13,7 @@ const fakeEventTarget = {
someOtherField: 42
};

// should not throw when calling the custom inspect method
// Should not throw when calling the custom inspect method
const output = util.inspect(fakeEventTarget);

assert.strictEqual(typeof output, 'string');

Loading