Skip to content

build: expose libplatform symbols in shared libnode #61144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jan 5, 2026
Merged

build: expose libplatform symbols in shared libnode #61144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb78a9
build: expose libplatform symbols in shared libnode
joyeecheung Dec 21, 2025
9c06ef0
fixup! build: expose libplatform symbols in shared libnode
joyeecheung Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: expose libplatform symbols in shared libnode 
This requires setting BUILDING_V8_PLATFORM_SHARED to expose the
public symbols since we build with hidden visibility by default.
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 21, 2025
commit abb78a92ecfd579687b1d4817a58808f51d147f1
2 changes: 2 additions & 0 deletions node.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,11 @@
'defines': [
'USING_UV_SHARED',
'USING_V8_SHARED',
'USING_V8_PLATFORM_SHARED',
'BUILDING_NODE_EXTENSION'
],
'defines!': [
'BUILDING_V8_PLATFORM_SHARED=1',
'BUILDING_V8_SHARED=1',
'BUILDING_UV_SHARED=1'
]
Expand Down
8 changes: 8 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
['OS!="aix" and OS!="os400"', {
'defines': [
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
'BUILDING_V8_PLATFORM_SHARED', # Make V8_PLATFORM_EXPORT visible.
]
}],
['node_shared=="true"', {
Expand Down Expand Up @@ -1345,6 +1346,7 @@
['component=="shared_library"', {
'defines': [
'BUILDING_V8_SHARED',
'BUILDING_V8_PLATFORM_SHARED',
],
}],
['v8_enable_i18n_support==1', {
Expand Down Expand Up @@ -1414,6 +1416,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'cflags_cc!': ['-fno-exceptions'],
'cflags_cc': ['-fexceptions'],
Expand All @@ -1440,6 +1443,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'cflags_cc!': ['-fno-exceptions'],
'cflags_cc': ['-fexceptions'],
Expand Down Expand Up @@ -1781,6 +1785,7 @@
],
'defines!': [
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'dependencies': [
'v8_libbase',
Expand Down Expand Up @@ -1862,6 +1867,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'cflags_cc!': ['-fno-exceptions'],
'cflags_cc': ['-fexceptions'],
Expand Down Expand Up @@ -1905,6 +1911,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'msvs_settings': {
'VCCLCompilerTool': {
Expand Down Expand Up @@ -2119,6 +2126,7 @@
],
'defines': [
'BUILDING_V8_SHARED',
'BUILDING_V8_PLATFORM_SHARED',
],
'direct_dependent_settings': {
'defines': [
Expand Down
Loading