Skip to content

stream: add kStreamBase marker for internal pipe optimization #61277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertcanaltin wants to merge 4 commits into
base: main
Choose a base branch
from
+336 −2
Open

stream: add kStreamBase marker for internal pipe optimization #61277

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58011f6
stream: add kStreamBase marker for internal pipe optimization
mertcanaltin Jan 4, 2026
2828147
update comments
mertcanaltin Jan 4, 2026
7fdc21f
stream: optimize internal pipe handling with optional chaining
mertcanaltin Jan 6, 2026
0ef5be9
stream: enhance internal pipe handling with additional error manageme…
mertcanaltin Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comments
  • Loading branch information
@mertcanaltin
mertcanaltin committed Jan 4, 2026
commit 2828147db8ab06b0d2b5a87bee95e0990ede38a3
10 changes: 5 additions & 5 deletions test/parallel/test-whatwg-webstreams-internal-pipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const {
JSStream,
} = internalBinding('js_stream');

// Test 1: kStreamBase marker is attached to ReadableStream
// kStreamBase marker is attached to ReadableStream
{
const stream = new JSStream();
const readable = newReadableStreamFromStreamBase(stream);
Expand All @@ -40,7 +40,7 @@ const {
stream.emitEOF();
}

// Test 2: kStreamBase marker is attached to WritableStream
// kStreamBase marker is attached to WritableStream
{
const stream = new JSStream();
stream.onwrite = common.mustNotCall();
Expand All @@ -54,7 +54,7 @@ const {
writable.close();
}

// Test 3: Regular JS streams don't have kStreamBase
// Regular JS streams don't have kStreamBase
{
const { ReadableStream, WritableStream } = require('stream/web');

Expand All @@ -76,7 +76,7 @@ const {
rs.pipeTo(ws).then(common.mustCall());
}

// Test 4: Mixed streams (one internal, one JS) use standard path
// Mixed streams (one internal, one JS) use standard path
{
const stream = new JSStream();
stream.onshutdown = (req) => req.oncomplete();
Expand Down Expand Up @@ -104,7 +104,7 @@ const {
}));
}

// Test 5: Verify kStreamBase is the correct symbol from util
// Verify kStreamBase is the correct symbol from util
{
const {
kStreamBase: kStreamBase2,
Expand Down
Loading