Update Ada and url web-platform tests #61315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
anonrig
added
the
commit-queue-rebase
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61315 +/- ##
==========================================
+ Coverage 88.00% 88.53% +0.53%
==========================================
Files 704 704
Lines 208739 208739
Branches 40196 40272 +76
==========================================
+ Hits 183706 184817 +1111
+ Misses 16992 15916 -1076
+ Partials 8041 8006 -35 🚀 New features to boost your workflow:
|
github-actions
bot
added
request-ci-failed
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/20832022492 |
KhafraDev
approved these changes
Jan 9, 2026
KhafraDev
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 45e37d9...5d9855b |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
PR-URL: #61315 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
PR-URL: #61315 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
aduh95
reviewed
Jan 17, 2026
| @@ -10515,14 +11228,14 @@ constructor_string_parser<regex_provider>::parse(std::string_view input) { | |||
| #ifndef ADA_ADA_VERSION_H | |||
| #define ADA_ADA_VERSION_H | |||
|
|
|||
| #define ADA_VERSION "3.3.0" | |||
| #define ADA_VERSION "3.4.1" | |||
Contributor
There was a problem hiding this comment.
The commit message is confusing, it says 3.4.0, but it's actually 3.4.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's update Ada that comes with several performance improvements.