Skip to content

Conversation

@joyeecheung
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/devcontainer

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it by:

  1. visiting https://github.com/joyeecheung/node/tree/update-devcontainer
  2. pressed . on my keyboard to open the web IDE,
  3. from the command palette (Cmd+Shift+P) I typed Toggle Terminal,
  4. then I pressed Continue Working in GitHub Codespaces.
  5. From there, I confirmed that running make build-ci -j4 was able to reuse the cached build artefacts (i.e. it only recompiles the diff of what landed on the local clone since the last docker image was built).

@bnb
Copy link
Contributor

bnb commented Jan 19, 2026

If you follow @aduh95's steps, I'd recommend using the largest machine type available - it'll make things smoother. The smallest machine type will run out of space in the initial build.

edit: the second biggest machine type will die when running make build-ci -j4. Would definitely recommend just defaulting to the largest.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 19, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2026
@nodejs-github-bot nodejs-github-bot merged commit bc9ffc3 into nodejs:main Jan 19, 2026
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bc9ffc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants