Move longestCommonPrefix outside tab complete

lib/repl.js

@@ -1049,6 +1049,25 @@ function complete(line, callback) {
   }
 }
 
+function longestCommonPrefix(arr = []) {
+  const cnt = arr.length;
+  if (cnt === 0) return '';
+  if (cnt === 1) return arr[0];
+
+  const first = arr[0];
+  // complexity: O(m * n)
+  for (let m = 0; m < first.length; m++) {
+    const c = first[m];
+    for (let n = 1; n < cnt; n++) {
+      const entry = arr[n];
+      if (m >= entry.length || c !== entry[m]) {
+        return first.substring(0, m);
+      }
+    }
+  }
+  return first;
+}
+
 REPLServer.prototype.completeOnEditorMode = (callback) => (err, results) => {
   if (err) return callback(err);
 
@@ -1062,25 +1081,6 @@ REPLServer.prototype.completeOnEditorMode = (callback) => (err, results) => {
   const data = completions.filter(isNotEmpty).map(trimCompleteOnPrefix);
 
   callback(null, [[`${completeOn}${longestCommonPrefix(data)}`], completeOn]);
-
-  function longestCommonPrefix(arr = []) {
-    const cnt = arr.length;
-    if (cnt === 0) return '';
-    if (cnt === 1) return arr[0];
-
-    const first = arr[0];
-    // complexity: O(m * n)
-    for (let m = 0; m < first.length; m++) {
-      const c = first[m];
-      for (let n = 1; n < cnt; n++) {
-        const entry = arr[n];
-        if (m >= entry.length || c !== entry[m]) {
-          return first.substring(0, m);
-        }
-      }
-    }
-    return first;
-  }
 };
 
 /**

test/parallel/test-repl-.editor.js

@@ -31,7 +31,7 @@ function run(input, output, event) {
   stream.emit('data', input);
   replServer.write('', event);
   replServer.close();
-  assert(found === expected, `Expected: ${expected}, Found: ${found}`);
+  assert.strictEqual(found, expected);
 }
 
 const tests = [