Skip to content

assert: Fix deepEqual/deepStrictEqual on equivalent typed arrays #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feross wants to merge 2 commits into from
Closed

assert: Fix deepEqual/deepStrictEqual on equivalent typed arrays #8002

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebc9894
assert: Fix deepEqual/deepStrictEqual on equivalent typed arrays
feross Aug 6, 2016
9e7e7c3
assert: Add deepEqual/deepStrictEqual tests for typed arrays
feross Aug 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
assert: Fix deepEqual/deepStrictEqual on equivalent typed arrays 
The typed array's underlying ArrayBuffer is used in `Buffer.from`.
Let's respect it's .byteOffset or .byteLength (i.e. position within the
parent ArrayBuffer).

Fixes: #8001
  • Loading branch information
@feross
feross committed Aug 7, 2016
commit ebc989401854e5b7da366973e9006ca69642dcae
8 changes: 6 additions & 2 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,12 @@ function _deepEqual(actual, expected, strict, memos) {
pToString(actual) === pToString(expected) &&
!(actual instanceof Float32Array ||
actual instanceof Float64Array)) {
return compare(Buffer.from(actual.buffer),
Buffer.from(expected.buffer)) === 0;
return compare(Buffer.from(actual.buffer,
actual.byteOffset,
actual.byteLength),
Buffer.from(expected.buffer,
expected.byteOffset,
expected.byteLength)) === 0;

// 7.5 For all other Object pairs, including Array objects, equivalence is
// determined by having the same number of owned properties (as verified
Expand Down