Skip to content

readline: key interval delay for \r & \n #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
princejwesley wants to merge 7 commits into from
Closed

readline: key interval delay for \r & \n #8109

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0fb6ffb
readline: key interval delay for \r & \n
princejwesley Aug 15, 2016
eb49af7
Braces for block scope
princejwesley Aug 15, 2016
a13083d
Configurable delay option
princejwesley Aug 15, 2016
f5cf531
option name & alignment fix
princejwesley Aug 16, 2016
515627c
Coerce to Min/max range
princejwesley Aug 16, 2016
3b1b84e
scoped tests
princejwesley Aug 21, 2016
9ed8f55
wrap function with mustCall
princejwesley Aug 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
wrap function with mustCall
  • Loading branch information
@princejwesley
princejwesley committed Aug 24, 2016
commit 9ed8f558fc1d890dcc3518d13bc250890e3debea
4 changes: 2 additions & 2 deletions test/parallel/test-readline-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,11 @@ function isWarned(emitter) {
callCount++;
});
fi.emit('data', '\r');
setTimeout(() => {
setTimeout(common.mustCall(() => {
fi.emit('data', '\n');
assert.equal(callCount, 2);
rli.close();
}, delay * 2);
}), delay * 2);
}

// \t when there is no completer function should behave like an ordinary
Expand Down